[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 08/13] iotests: filter few more luks specific create options
From: |
Maxim Levitsky |
Subject: |
Re: [PATCH 08/13] iotests: filter few more luks specific create options |
Date: |
Thu, 30 Jan 2020 18:12:09 +0200 |
On Tue, 2020-01-28 at 17:36 +0000, Daniel P. Berrangé wrote:
> On Tue, Jan 14, 2020 at 09:33:45PM +0200, Maxim Levitsky wrote:
> > This allows more tests to be able to have same output on both qcow2 luks
> > encrypted images
> > and raw luks images
> >
> > Signed-off-by: Maxim Levitsky <address@hidden>
> > ---
> > tests/qemu-iotests/087.out | 6 +++---
> > tests/qemu-iotests/134.out | 2 +-
> > tests/qemu-iotests/158.out | 4 ++--
> > tests/qemu-iotests/188.out | 2 +-
> > tests/qemu-iotests/189.out | 4 ++--
> > tests/qemu-iotests/198.out | 4 ++--
> > tests/qemu-iotests/common.filter | 6 ++++--
> > 7 files changed, 15 insertions(+), 13 deletions(-)
> >
> > diff --git a/tests/qemu-iotests/087.out b/tests/qemu-iotests/087.out
> > index 2d92ea847b..b61ba638af 100644
> > --- a/tests/qemu-iotests/087.out
> > +++ b/tests/qemu-iotests/087.out
> > @@ -34,7 +34,7 @@ QMP_VERSION
>
> 1>
> > === Encrypted image QCow ===
> >
> > -Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728 encryption=on
> > encrypt.key-secret=sec0
> > +Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728 encryption=on
>
> I'm not convinced about this - it feels like this is throwing
> away relevant info to be validated about the test scenario
This is mostly echo of the input info so it is only nice to have to debug the
test IMHO.
>
> Can you give more info about the scenario this benefits us in ?
This allows me to have same test output for raw luks and qcow2, and thus
use mostly the same test (sans adding the encrypt.* prefix everywhere) for both
luks and qcow2.
Best regards,
Maxim Levitsky
>
> Regards,
> Daniel
- Re: [PATCH 02/13] qcrypto-luks: implement encryption key management, (continued)
- [PATCH 03/13] block: amend: add 'force' option, Maxim Levitsky, 2020/01/14
- [PATCH 04/13] block: amend: separate amend and create options for qemu-img, Maxim Levitsky, 2020/01/14
- [PATCH 05/13] block/crypto: rename two functions, Maxim Levitsky, 2020/01/14
- [PATCH 08/13] iotests: filter few more luks specific create options, Maxim Levitsky, 2020/01/14
- [PATCH 07/13] qcow2: extend qemu-img amend interface with crypto options, Maxim Levitsky, 2020/01/14
- [PATCH 06/13] block/crypto: implement the encryption key management, Maxim Levitsky, 2020/01/14
- [PATCH 10/13] block: add generic infrastructure for x-blockdev-amend qmp command, Maxim Levitsky, 2020/01/14
- [PATCH 09/13] qemu-iotests: qemu-img tests for luks key management, Maxim Levitsky, 2020/01/14