[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 4/5] qcow2: Don't require aligned offsets in qcow2_co_copy_ran
From: |
Alberto Garcia |
Subject: |
[PATCH v3 4/5] qcow2: Don't require aligned offsets in qcow2_co_copy_range_from() |
Date: |
Sat, 18 Jan 2020 20:09:29 +0100 |
qemu-img's convert_co_copy_range() operates at the sector level and
block_copy() operates at the cluster level so this condition is always
true, but it is not necessary to restrict this here, so let's leave it
to the driver implementation return an error if there is any.
Signed-off-by: Alberto Garcia <address@hidden>
---
block/qcow2.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 100393fd3b..a6b0d4ee1d 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -3829,10 +3829,6 @@ qcow2_co_copy_range_from(BlockDriverState *bs,
case QCOW2_CLUSTER_NORMAL:
child = s->data_file;
copy_offset += offset_into_cluster(s, src_offset);
- if ((copy_offset & 511) != 0) {
- ret = -EIO;
- goto out;
- }
break;
default:
--
2.20.1
- [PATCH v3 0/5] Misc BDRV_SECTOR_SIZE updates, Alberto Garcia, 2020/01/18
- [PATCH v3 5/5] qcow2: Use BDRV_SECTOR_SIZE instead of the hardcoded value, Alberto Garcia, 2020/01/18
- [PATCH v3 4/5] qcow2: Don't require aligned offsets in qcow2_co_copy_range_from(),
Alberto Garcia <=
- [PATCH v3 2/5] qcow2: Tighten cluster_offset alignment assertions, Alberto Garcia, 2020/01/18
- [PATCH v3 1/5] qcow2: Don't round the L1 table allocation up to the sector size, Alberto Garcia, 2020/01/18
- [PATCH v3 3/5] qcow2: Use bs->bl.request_alignment when updating an L1 entry, Alberto Garcia, 2020/01/18
- Re: [PATCH v3 0/5] Misc BDRV_SECTOR_SIZE updates, Max Reitz, 2020/01/21