[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 2/2] iotests: add test for backup-top failure on permission activ
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[PATCH 2/2] iotests: add test for backup-top failure on permission activation |
Date: |
Thu, 16 Jan 2020 18:54:52 +0300 |
This test checks that bug is really fixed by previous commit.
Cc: address@hidden # v4.2.0
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
---
tests/qemu-iotests/283 | 75 ++++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/283.out | 8 ++++
tests/qemu-iotests/group | 1 +
3 files changed, 84 insertions(+)
create mode 100644 tests/qemu-iotests/283
create mode 100644 tests/qemu-iotests/283.out
diff --git a/tests/qemu-iotests/283 b/tests/qemu-iotests/283
new file mode 100644
index 0000000000..f0f216d109
--- /dev/null
+++ b/tests/qemu-iotests/283
@@ -0,0 +1,75 @@
+#!/usr/bin/env python
+#
+# Test for backup-top filter permission activation failure
+#
+# Copyright (c) 2019 Virtuozzo International GmbH.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+#
+
+import iotests
+
+# The test is unrelated to formats, restrict it to qcow2 to avoid extra runs
+iotests.verify_image_format(supported_fmts=['qcow2'])
+
+size = 1024 * 1024
+
+"""
+On activation, backup-top is going to unshare write permission on its
+source child. It will be impossible for the following configuration:
+
+ ┌────────┐ target ┌─────────────┐
+ │ target │ ◀─────── │ backup_top │
+ └────────┘ └─────────────┘
+ │
+ │ backing
+ ▼
+ ┌─────────────┐
+ │ source │
+ └─────────────┘
+ │
+ │ file
+ ▼
+ ┌─────────────┐ write perm ┌───────┐
+ │ base │ ◀──────────── │ other │
+ └─────────────┘ └───────┘
+
+Write unsharing will be propagated to the "source->base"link and will
+conflict with other node write permission.
+
+(Note, that we can't just consider source to be direct child of other,
+as in this case this link will be broken, when backup_top is appended)
+"""
+
+vm = iotests.VM()
+vm.launch()
+
+vm.qmp_log('blockdev-add', **{'node-name': 'target', 'driver': 'null-co'})
+
+vm.qmp_log('blockdev-add', **{
+ 'node-name': 'source',
+ 'driver': 'blkdebug',
+ 'image': {'node-name': 'base', 'driver': 'null-co', 'size': size}
+})
+
+vm.qmp_log('blockdev-add', **{
+ 'node-name': 'other',
+ 'driver': 'blkdebug',
+ 'image': 'base',
+ 'take-child-perms': ['write']
+})
+
+vm.qmp_log('blockdev-backup', sync='full', device='source', target='target')
+
+vm.shutdown()
diff --git a/tests/qemu-iotests/283.out b/tests/qemu-iotests/283.out
new file mode 100644
index 0000000000..daaf5828c1
--- /dev/null
+++ b/tests/qemu-iotests/283.out
@@ -0,0 +1,8 @@
+{"execute": "blockdev-add", "arguments": {"driver": "null-co", "node-name":
"target"}}
+{"return": {}}
+{"execute": "blockdev-add", "arguments": {"driver": "blkdebug", "image":
{"driver": "null-co", "node-name": "base", "size": 1048576}, "node-name":
"source"}}
+{"return": {}}
+{"execute": "blockdev-add", "arguments": {"driver": "blkdebug", "image":
"base", "node-name": "other", "take-child-perms": ["write"]}}
+{"return": {}}
+{"execute": "blockdev-backup", "arguments": {"device": "source", "sync":
"full", "target": "target"}}
+{"error": {"class": "GenericError", "desc": "Cannot set permissions for
backup-top filter: Conflicts with use by other as 'image', which uses 'write'
on base"}}
diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group
index cb2b789e44..d827e8c821 100644
--- a/tests/qemu-iotests/group
+++ b/tests/qemu-iotests/group
@@ -288,3 +288,4 @@
277 rw quick
279 rw backing quick
280 rw migration quick
+283 auto quick
--
2.21.0
- [PATCH 0/2] backup-top failure path fix, Vladimir Sementsov-Ogievskiy, 2020/01/16
- [PATCH 2/2] iotests: add test for backup-top failure on permission activation,
Vladimir Sementsov-Ogievskiy <=
- Re: [PATCH 2/2] iotests: add test for backup-top failure on permission activation, Max Reitz, 2020/01/20
- Re: [PATCH 2/2] iotests: add test for backup-top failure on permission activation, Vladimir Sementsov-Ogievskiy, 2020/01/20
- Re: [PATCH 2/2] iotests: add test for backup-top failure on permission activation, Max Reitz, 2020/01/21
- Re: [PATCH 2/2] iotests: add test for backup-top failure on permission activation, Vladimir Sementsov-Ogievskiy, 2020/01/21
- Re: [PATCH 2/2] iotests: add test for backup-top failure on permission activation, Max Reitz, 2020/01/21
- Re: [PATCH 2/2] iotests: add test for backup-top failure on permission activation, Vladimir Sementsov-Ogievskiy, 2020/01/21
- Re: [PATCH 2/2] iotests: add test for backup-top failure on permission activation, Max Reitz, 2020/01/21
- Re: [PATCH 2/2] iotests: add test for backup-top failure on permission activation, Vladimir Sementsov-Ogievskiy, 2020/01/21
- Re: [PATCH 2/2] iotests: add test for backup-top failure on permission activation, Max Reitz, 2020/01/21
- Re: [PATCH 2/2] iotests: add test for backup-top failure on permission activation, Vladimir Sementsov-Ogievskiy, 2020/01/21