[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] block: fix memleaks in bdrv_refresh_filename
From: |
Max Reitz |
Subject: |
Re: [PATCH] block: fix memleaks in bdrv_refresh_filename |
Date: |
Thu, 16 Jan 2020 10:10:29 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 |
On 16.01.20 09:56, address@hidden wrote:
> From: Pan Nengyuan <address@hidden>
>
> If we call the qmp 'query-block' while qemu is working on
> 'block-commit', it will cause memleaks, the memory leak stack is as
> follow:
>
> Indirect leak of 12360 byte(s) in 3 object(s) allocated from:
> #0 0x7f80f0b6d970 in __interceptor_calloc (/lib64/libasan.so.5+0xef970)
> #1 0x7f80ee86049d in g_malloc0 (/lib64/libglib-2.0.so.0+0x5249d)
> #2 0x55ea95b5bb67 in qdict_new /mnt/sdb/qemu-4.2.0-rc0/qobject/qdict.c:29
> #3 0x55ea956cd043 in bdrv_refresh_filename
> /mnt/sdb/qemu-4.2.0-rc0/block.c:6427
> #4 0x55ea956cc950 in bdrv_refresh_filename
> /mnt/sdb/qemu-4.2.0-rc0/block.c:6399
> #5 0x55ea956cc950 in bdrv_refresh_filename
> /mnt/sdb/qemu-4.2.0-rc0/block.c:6399
> #6 0x55ea956cc950 in bdrv_refresh_filename
> /mnt/sdb/qemu-4.2.0-rc0/block.c:6399
> #7 0x55ea958818ea in bdrv_block_device_info
> /mnt/sdb/qemu-4.2.0-rc0/block/qapi.c:56
> #8 0x55ea958879de in bdrv_query_info
> /mnt/sdb/qemu-4.2.0-rc0/block/qapi.c:392
> #9 0x55ea9588b58f in qmp_query_block
> /mnt/sdb/qemu-4.2.0-rc0/block/qapi.c:578
> #10 0x55ea95567392 in qmp_marshal_query_block
> qapi/qapi-commands-block-core.c:95
>
> Indirect leak of 4120 byte(s) in 1 object(s) allocated from:
> #0 0x7f80f0b6d970 in __interceptor_calloc (/lib64/libasan.so.5+0xef970)
> #1 0x7f80ee86049d in g_malloc0 (/lib64/libglib-2.0.so.0+0x5249d)
> #2 0x55ea95b5bb67 in qdict_new /mnt/sdb/qemu-4.2.0-rc0/qobject/qdict.c:29
> #3 0x55ea956cd043 in bdrv_refresh_filename
> /mnt/sdb/qemu-4.2.0-rc0/block.c:6427
> #4 0x55ea956cc950 in bdrv_refresh_filename
> /mnt/sdb/qemu-4.2.0-rc0/block.c:6399
> #5 0x55ea956cc950 in bdrv_refresh_filename
> /mnt/sdb/qemu-4.2.0-rc0/block.c:6399
> #6 0x55ea9569f301 in bdrv_backing_attach
> /mnt/sdb/qemu-4.2.0-rc0/block.c:1064
> #7 0x55ea956a99dd in bdrv_replace_child_noperm
> /mnt/sdb/qemu-4.2.0-rc0/block.c:2283
> #8 0x55ea956b9b53 in bdrv_replace_node
> /mnt/sdb/qemu-4.2.0-rc0/block.c:4196
> #9 0x55ea956b9e49 in bdrv_append /mnt/sdb/qemu-4.2.0-rc0/block.c:4236
> #10 0x55ea958c3472 in commit_start
> /mnt/sdb/qemu-4.2.0-rc0/block/commit.c:306
> #11 0x55ea94b68ab0 in qmp_block_commit
> /mnt/sdb/qemu-4.2.0-rc0/blockdev.c:3459
> #12 0x55ea9556a7a7 in qmp_marshal_block_commit
> qapi/qapi-commands-block-core.c:407
>
> Fixes: bb808d5f5c0978828a974d547e6032402c339555
> Reported-by: Euler Robot <address@hidden>
> Signed-off-by: Pan Nengyuan <address@hidden>
> ---
> block.c | 1 +
> 1 file changed, 1 insertion(+)
Thanks, applied to my block branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block
Max
signature.asc
Description: OpenPGP digital signature