[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 4/4] block: Mark 'block_resize' as coroutine
From: |
Kevin Wolf |
Subject: |
[PATCH v2 4/4] block: Mark 'block_resize' as coroutine |
Date: |
Tue, 14 Jan 2020 19:27:35 +0100 |
block_resize is safe to run in a coroutine, so use it as an example for
the new 'coroutine': true annotation in the QAPI schema.
Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
---
qapi/block-core.json | 3 ++-
blockdev.c | 6 +++---
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 7ff5e5edaf..1dbb2a9901 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -1341,7 +1341,8 @@
{ 'command': 'block_resize',
'data': { '*device': 'str',
'*node-name': 'str',
- 'size': 'int' } }
+ 'size': 'int' },
+ 'coroutine': true }
##
# @NewImageMode:
diff --git a/blockdev.c b/blockdev.c
index 8e029e9c01..b5e5d1e072 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -3161,9 +3161,9 @@ void hmp_drive_del(Monitor *mon, const QDict *qdict)
aio_context_release(aio_context);
}
-void qmp_block_resize(bool has_device, const char *device,
- bool has_node_name, const char *node_name,
- int64_t size, Error **errp)
+void coroutine_fn qmp_block_resize(bool has_device, const char *device,
+ bool has_node_name, const char *node_name,
+ int64_t size, Error **errp)
{
Error *local_err = NULL;
BlockBackend *blk = NULL;
--
2.20.1
- [PATCH v2 0/4] qmp: Optionally run handlers in coroutines, Kevin Wolf, 2020/01/14
- [PATCH v2 1/4] qapi: Add a 'coroutine' flag for commands, Kevin Wolf, 2020/01/14
- [PATCH v2 2/4] vl: Initialise main loop earlier, Kevin Wolf, 2020/01/14
- [PATCH v2 3/4] qmp: Move dispatcher to a coroutine, Kevin Wolf, 2020/01/14
- [PATCH v2 4/4] block: Mark 'block_resize' as coroutine,
Kevin Wolf <=
- Re: [PATCH v2 0/4] qmp: Optionally run handlers in coroutines, Daniel P . Berrangé, 2020/01/14
- Re: [PATCH v2 0/4] qmp: Optionally run handlers in coroutines, no-reply, 2020/01/14
- Re: [PATCH v2 0/4] qmp: Optionally run handlers in coroutines, Stefan Hajnoczi, 2020/01/15