[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 3/5] nbd: fix uninitialized variable warning
From: |
Laurent Vivier |
Subject: |
[PULL 3/5] nbd: fix uninitialized variable warning |
Date: |
Wed, 8 Jan 2020 17:02:31 +0100 |
From: Pan Nengyuan <address@hidden>
Fixes:
/mnt/sdb/qemu/nbd/server.c: In function 'nbd_handle_request':
/mnt/sdb/qemu/nbd/server.c:2313:9: error: 'ret' may be used uninitialized in
this function [-Werror=maybe-uninitialized]
int ret;
Reported-by: Euler Robot <address@hidden>
Signed-off-by: Pan Nengyuan <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
---
nbd/server.c | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/nbd/server.c b/nbd/server.c
index 24ebc1a80571..87fcd2e7bfac 100644
--- a/nbd/server.c
+++ b/nbd/server.c
@@ -2384,20 +2384,12 @@ static coroutine_fn int nbd_handle_request(NBDClient
*client,
!client->export_meta.bitmap,
NBD_META_ID_BASE_ALLOCATION,
errp);
- if (ret < 0) {
- return ret;
- }
- }
-
- if (client->export_meta.bitmap) {
+ } else { /* client->export_meta.bitmap */
ret = nbd_co_send_bitmap(client, request->handle,
client->exp->export_bitmap,
request->from, request->len,
dont_fragment,
true, NBD_META_ID_DIRTY_BITMAP, errp);
- if (ret < 0) {
- return ret;
- }
}
return ret;
--
2.24.1
- [PULL 0/5] Trivial branch patches, Laurent Vivier, 2020/01/08
- [PULL 1/5] MAINTAINERS: Update Yuval Shaia's email address, Laurent Vivier, 2020/01/08
- [PULL 2/5] util/module: fix a memory leak, Laurent Vivier, 2020/01/08
- [PULL 3/5] nbd: fix uninitialized variable warning,
Laurent Vivier <=
- [PULL 4/5] arm/translate-a64: fix uninitialized variable warning, Laurent Vivier, 2020/01/08
- [PULL 5/5] vl: fix memory leak in configure_accelerators, Laurent Vivier, 2020/01/08
- Re: [PULL 0/5] Trivial branch patches, Peter Maydell, 2020/01/13