qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/9] monitor: move hmp_drive_del and hmp_commit to blockdev-h


From: Markus Armbruster
Subject: Re: [PATCH 3/9] monitor: move hmp_drive_del and hmp_commit to blockdev-hmp-cmds.c
Date: Wed, 27 Nov 2019 08:29:58 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)

Maxim Levitsky <address@hidden> writes:

> Signed-off-by: Maxim Levitsky <address@hidden>
> ---
>  blockdev-hmp-cmds.c | 97 ++++++++++++++++++++++++++++++++++++++++++++-
>  blockdev.c          | 95 --------------------------------------------
>  2 files changed, 96 insertions(+), 96 deletions(-)
>
> diff --git a/blockdev-hmp-cmds.c b/blockdev-hmp-cmds.c
> index 21ff6fa9a9..8884618238 100644
> --- a/blockdev-hmp-cmds.c
> +++ b/blockdev-hmp-cmds.c
> @@ -33,7 +33,7 @@
>  #include "sysemu/sysemu.h"
>  #include "monitor/monitor.h"
>  #include "block/block_int.h"
> -
> +#include "qapi/qapi-commands-block.h"

I prefer keeping qapi/ stuff together.  Please add this right before
#include "qapi/qmp/qdict.h".

[...]




reply via email to

[Prev in Thread] Current Thread [Next in Thread]