Re: [PATCH v3 8/8] iotests: Test committing to short backing file

[Max Reitz]

On 22.11.19 17:05, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  tests/qemu-iotests/274        | 152 +++++++++++++++++++++++++
>  tests/qemu-iotests/274.out    | 203 ++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/group      |   1 +
>  tests/qemu-iotests/iotests.py |   2 +-
>  4 files changed, 357 insertions(+), 1 deletion(-)
>  create mode 100755 tests/qemu-iotests/274
>  create mode 100644 tests/qemu-iotests/274.out

[...]

> diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
> index b46d298766..9135dd52b6 100644
> --- a/tests/qemu-iotests/iotests.py
> +++ b/tests/qemu-iotests/iotests.py
> @@ -149,7 +149,7 @@ def img_info_log(filename, filter_path=None, 
> imgopts=False, extra_args=[]):
>      output = qemu_img_pipe(*args)
>      if not filter_path:
>          filter_path = filename
> -    log(filter_img_info(output, filter_path))
> +    log(filter_img_info(output, filter_path), filters=[filter_testfiles])

This doesn’t work when the path contains $IMGFMT.  The test dir filter
must then run before the image format filter.  For example, I usually
run the tests in /tmp/test-${IMGFMT}-${IMGPROTO} (i.e.
/tmp/test-qcow2-file for -qcow2), and this test fails for me:

@@ -49,7 +49,7 @@
 file format: IMGFMT
 virtual size: 2 MiB (2097152 bytes)
 cluster_size: 65536
-backing file: TEST_DIR/PID-base
+backing file: /tmp/test-IMGFMT-file/40083-base
 Format specific information:
     compat: 1.1
     lazy refcounts: false

Max

signature.asc
Description: OpenPGP digital signature