Re: [PATCH v3 1/8] blockdev: merge drive_backup_prepare with do_drive_backup

[Max Reitz]

On 12.11.19 12:30, Sergio Lopez wrote:
> Consolidate drive_backup_prepare() with do_drive_backup() as a first
> step towards streamlining all functionality through transactions.
> 
> Signed-off-by: Sergio Lopez <address@hidden>
> ---
>  blockdev.c | 58 +++++++++++++++---------------------------------------
>  1 file changed, 16 insertions(+), 42 deletions(-)

qemu no longer compiles with this patch applied, for two reasons:

(1) actions[TRANSACTION_ACTION_KIND_DRIVE_BACKUP].prepare is initialized
with drive_backup_prepare on line 2175, but this patch merges it into
do_drive_backup(), which is only on line 3556, so we need a forward
declaration.

(2) qmp_drive_backup() calls do_drive_backup(), but that function no
longer exists.

Max

signature.asc
Description: OpenPGP digital signature