Re: [Qemu-devel] [PATCH v4 02/14] qapi: Move to_c_string() to common.py

[Max Reitz]

On 14.11.19 10:20, Markus Armbruster wrote:
> Max Reitz <address@hidden> writes:
> 
>> This function will be useful for code generation once we allow default
>> values, so move it to the other "C helper functions".  In the process,
>> rewrite it so it supports all nonprintable and non-ASCII characters.
>>
>> Signed-off-by: Max Reitz <address@hidden>
> 
> Please have a close look at commit 56a8caff92 "qapi: Restrict strings to
> printable ASCII".  Do we still need the rewrite?

If that’s all that has changed, I think we will still need at least some
bits, like the " or \ escaping.

Also, actually, it looks like 56a8caff92 didn’t change the fact that
control characters are verbatim parts of the string, i.e. \u000a will
still be a literal 0xa byte, and as such must be escaped anew in the C
string.

So without having tried, I think this is still very much necessary.

> If yes: the commit message title promises code motion, but the patch is
> anything but.  Adjust the title, please.

OK.

Max

signature.asc
Description: OpenPGP digital signature