|
| From: | Eric Blake |
| Subject: | Re: [PATCH v3 for-4.2 0/4] Better NBD string length handling |
| Date: | Wed, 13 Nov 2019 21:04:22 -0600 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 |
On 11/13/19 9:00 PM, address@hidden wrote:
Patchew URL: https://patchew.org/QEMU/address@hidden/
from /tmp/qemu-test/src/include/qemu/osdep.h:140,
from /tmp/qemu-test/src/nbd/server.c:20:
/tmp/qemu-test/src/nbd/server.c: In function 'nbd_negotiate_handle_export_name':
/usr/x86_64-w64-mingw32/sys-root/mingw/include/glib-2.0/glib/glib-autocleanups.h:28:3:
error: 'name' may be used uninitialized in this function
[-Werror=maybe-uninitialized]
g_free (*pp);
^~~~~~~~~~~~
/tmp/qemu-test/src/nbd/server.c:435:22: note: 'name' was declared here
g_autofree char *name;
^~~~
Ha - I posted the fix to that one minute before patchew flagged it. Still, I'm not sure why my gcc didn't flag this locally, while the mingw builder did.
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
| [Prev in Thread] | Current Thread | [Next in Thread] |