[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 04/20] nvme: populate the mandatory subnqn and ver fields
|
From: |
Klaus Birkelund |
|
Subject: |
Re: [PATCH v2 04/20] nvme: populate the mandatory subnqn and ver fields |
|
Date: |
Wed, 13 Nov 2019 07:16:55 +0100 |
|
User-agent: |
Mutt/1.12.2 (2019-09-21) |
On Tue, Nov 12, 2019 at 03:04:45PM +0000, Beata Michalska wrote:
> Hi Klaus
>
> On Tue, 15 Oct 2019 at 11:42, Klaus Jensen <address@hidden> wrote:
> > + n->bar.vs = 0x00010201;
>
> Very minor:
>
> The version number is being set twice in the patch series already.
> And it is being set in two places.
> It might be worth to make a #define out of it so that only one
> needs to be changed.
>
I think you are right. I'll do that.