Re: [PATCH v4] iotests: Test NBD client reconnection

[Eric Blake]

On 11/11/19 4:04 AM, Andrey Shinkevich wrote:
> The test for an NBD client. The NBD server is disconnected after the
> client write request. The NBD client should reconnect and complete
> the write operation.
>
> Suggested-by: Denis V. Lunev <address@hidden>
> Suggested-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> Signed-off-by: Andrey Shinkevich <address@hidden>
> ---
> v3 was discussed in the email thread with the message ID
> <address@hidden>

> +import os
> +import subprocess
> +import iotests
> +from iotests import file_path, log
> +
> +
> +nbd_sock, conf_file = file_path('nbd-sock', "nbd-fault-injector.conf")

Mixing '' and "" in the same line is odd.  I don't know if we have a 
strong preference for one style over the other.

> +++ b/tests/qemu-iotests/group
> @@ -284,3 +284,4 @@
>  268 rw auto quick
>  270 rw backing quick
>  272 rw
> +277 rw

The test completes in 3 seconds for me; we could add 'quick'.

Otherwise, looks reasonable to me.

Reviewed-by: Eric Blake <address@hidden>
Tested-by: Eric Blake <address@hidden>

I'll probably queue this through my NBD tree for rc1, as it adds test 
coverage of a new feature for the 4.2 release.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org