[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 4/4] iotests: add test for virtio-scsi and virtio-blk mach
From: |
Eduardo Habkost |
Subject: |
Re: [PATCH v1 4/4] iotests: add test for virtio-scsi and virtio-blk machine type settings |
Date: |
Wed, 6 Nov 2019 16:26:41 -0300 |
On Wed, Nov 06, 2019 at 11:04:16AM +0100, Max Reitz wrote:
> On 06.11.19 10:24, Stefan Hajnoczi wrote:
> > On Tue, Nov 05, 2019 at 07:11:05PM +0300, Denis Plotnikov wrote:
> >> It tests proper queue size settings for all available machine types.
> >>
> >> Signed-off-by: Denis Plotnikov <address@hidden>
> >> ---
> >> tests/qemu-iotests/267 | 154 +++++++++++++++++++++++++++++++++++++
> >> tests/qemu-iotests/267.out | 1 +
> >> tests/qemu-iotests/group | 1 +
> >> 3 files changed, 156 insertions(+)
> >> create mode 100755 tests/qemu-iotests/267
> >> create mode 100644 tests/qemu-iotests/267.out
> >
> > The qemu-iotests maintainers might prefer for this to be at the
> > top-level in tests/ since it's not really an iotest, but the code itself
> > looks fine to me:
> >
> > Reviewed-by: Stefan Hajnoczi <address@hidden>
>
> Good question. I don’t really mind, but it would be weird if started
> adding all kinds of “external” qemu tests (i.e. that use QMP) in the
> iotests directory.
>
> What is the alternative? Just putting it in a different directory
> doesn’t sound that appealing to me either, because it would still depend
> on the iotests infrastructure, right? (i.e., iotests.py and check)
We do have tests/acceptance for simple test cases written in
Python. What's the reason for this test case to depend on the
iotests infrastructure?
--
Eduardo
- Re: [PATCH v1 1/4] virtio: protect non-modern devices from too big virtqueue size setting, (continued)
- Re: [PATCH v1 1/4] virtio: protect non-modern devices from too big virtqueue size setting, Stefan Hajnoczi, 2019/11/06
- Re: [PATCH v1 1/4] virtio: protect non-modern devices from too big virtqueue size setting, Stefan Hajnoczi, 2019/11/06
- Re: [PATCH v1 1/4] virtio: protect non-modern devices from too big virtqueue size setting, Michael S. Tsirkin, 2019/11/06
- Re: [PATCH v1 1/4] virtio: protect non-modern devices from too big virtqueue size setting, Stefan Hajnoczi, 2019/11/06
- Re: [PATCH v1 1/4] virtio: protect non-modern devices from too big virtqueue size setting, Michael S. Tsirkin, 2019/11/06
[PATCH v1 3/4] virtio: increase virtuqueue sizes in new machine types, Denis Plotnikov, 2019/11/05
[PATCH v1 4/4] iotests: add test for virtio-scsi and virtio-blk machine type settings, Denis Plotnikov, 2019/11/05