[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 01/13] block-crypto: misc refactoring
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v2 01/13] block-crypto: misc refactoring |
Date: |
Fri, 27 Sep 2019 11:15:35 +0100 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
On Thu, Sep 26, 2019 at 12:35:15AM +0300, Maxim Levitsky wrote:
> * rename the write_func to create_write_func,
> and init_func to create_init_func
> this is preparation for other write_func that will
> be used to update the encryption keys.
>
> No functional changes
>
> Signed-off-by: Maxim Levitsky <address@hidden>
> Reviewed-by: Daniel P. Berrangé <address@hidden>
> ---
> block/crypto.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/block/crypto.c b/block/crypto.c
> index 7eb698774e..6e822c6e50 100644
> --- a/block/crypto.c
> +++ b/block/crypto.c
> @@ -78,7 +78,7 @@ struct BlockCryptoCreateData {
> };
>
>
> -static ssize_t block_crypto_write_func(QCryptoBlock *block,
> +static ssize_t block_crypto_create_write_func(QCryptoBlock *block,
> size_t offset,
> const uint8_t *buf,
> size_t buflen,
The parameters need re-indenting when you change this name.
> @@ -96,8 +96,7 @@ static ssize_t block_crypto_write_func(QCryptoBlock *block,
> return ret;
> }
>
> -
> -static ssize_t block_crypto_init_func(QCryptoBlock *block,
> +static ssize_t block_crypto_create_init_func(QCryptoBlock *block,
> size_t headerlen,
> void *opaque,
> Error **errp)
And here
I dropped this one from the pull request, so please bundle it into your
other luks series
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH v2 00/13] crypto/luks: preparation for encryption key managment, Maxim Levitsky, 2019/09/25
- [PATCH v2 01/13] block-crypto: misc refactoring, Maxim Levitsky, 2019/09/25
- Re: [PATCH v2 01/13] block-crypto: misc refactoring,
Daniel P . Berrangé <=
- [PATCH v2 02/13] qcrypto-luks: rename some fields in QCryptoBlockLUKSHeader, Maxim Levitsky, 2019/09/25
- [PATCH v2 03/13] qcrypto-luks: don't overwrite cipher_mode in header, Maxim Levitsky, 2019/09/25
- [PATCH v2 04/13] qcrypto-luks: simplify masterkey and masterkey length, Maxim Levitsky, 2019/09/25
- [PATCH v2 05/13] qcrypto-luks: pass keyslot index rather that pointer to the keyslot, Maxim Levitsky, 2019/09/25
- [PATCH v2 06/13] qcrypto-luks: use the parsed encryption settings in QCryptoBlockLUKS, Maxim Levitsky, 2019/09/25
- [PATCH v2 07/13] qcrypto-luks: purge unused error codes from open callback, Maxim Levitsky, 2019/09/25
- [PATCH v2 08/13] qcrypto-luks: extract store and load header, Maxim Levitsky, 2019/09/25
- [PATCH v2 09/13] qcrypto-luks: extract check and parse header, Maxim Levitsky, 2019/09/25
- [PATCH v2 13/13] LUKS: better error message when creating too large files, Maxim Levitsky, 2019/09/25