[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 19/22] iotests: Use self.image_len in TestRepairQuorum
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
Re: [PATCH 19/22] iotests: Use self.image_len in TestRepairQuorum |
Date: |
Thu, 26 Sep 2019 14:13:45 +0000 |
20.09.2019 18:28, Max Reitz wrote:
> 041's TestRepairQuorum has its own image_len, no need to refer to
> TestSingleDrive. (This patch allows uncommenting TestSingleDrive to
you mean commenting
> speed up 041 during test testing.)
we definitely want a way to run a subset of test cases.
I usually do s/def test/def ntest/, and then set needed test-case back to
'def test'
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> tests/qemu-iotests/041 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041
> index ca126de3ff..20ae9750b7 100755
> --- a/tests/qemu-iotests/041
> +++ b/tests/qemu-iotests/041
> @@ -880,7 +880,7 @@ class TestRepairQuorum(iotests.QMPTestCase):
> # Add each individual quorum images
> for i in self.IMAGES:
> qemu_img('create', '-f', iotests.imgfmt, i,
> - str(TestSingleDrive.image_len))
> + str(self.image_len))
yes, seems TestSingleDrive.image_len is a copy-pasting mistake here..
> # Assign a node name to each quorum image in order to manipulate
> # them
> opts = "node-name=img%i" % self.IMAGES.index(i)
>
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
--
Best regards,
Vladimir
- Re: [PATCH 12/22] block: Remove bdrv_recurse_is_first_non_filter(), (continued)
- [PATCH 14/22] quorum: Stop marking it as a filter, Max Reitz, 2019/09/20
- [PATCH 15/22] mirror: Prevent loops, Max Reitz, 2019/09/20
- [PATCH 16/22] iotests: Use complete_and_wait() in 155, Max Reitz, 2019/09/20
- [PATCH 18/22] iotests: Resolve TODOs in 041, Max Reitz, 2019/09/20
- [PATCH 19/22] iotests: Use self.image_len in TestRepairQuorum, Max Reitz, 2019/09/20
- Re: [PATCH 19/22] iotests: Use self.image_len in TestRepairQuorum,
Vladimir Sementsov-Ogievskiy <=
- [PATCH 21/22] iotests: Check that @replaces can replace filters, Max Reitz, 2019/09/20
- [PATCH 22/22] iotests: Mirror must not attempt to create loops, Max Reitz, 2019/09/20
- [PATCH 20/22] iotests: Add tests for invalid Quorum @replaces, Max Reitz, 2019/09/20