[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 18/25] block: Fix error_append_hint usage
From: |
Eric Blake |
Subject: |
Re: [PATCH v3 18/25] block: Fix error_append_hint usage |
Date: |
Tue, 24 Sep 2019 16:03:59 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 9/24/19 3:08 PM, Vladimir Sementsov-Ogievskiy wrote:
> If we want append hint to errp, we must use ERRP_FUNCTION_BEGIN macro.
> Otherwise hint will not be appended in case of errp == &fatal_err
> (program will exit before error_append_hint() call). Fix such cases.
>
> This commit (together with its neighbors) was generated by
>
> git grep -l 'error_append_hint(errp' | while read f; do \
> spatch --sp-file scripts/coccinelle/fix-error_append_hint-usage.cocci \
> --in-place $f; done
>
> and then
>
> ./python/commit-per-subsystem.py MAINTAINERS "$(< auto-msg)"
>
> (auto-msg was a file with this commit message)
>
Your automation is cool!
> Still, for backporting it may be more comfortable to use only the first
> command and then do one huge commit.
>
> Reported-by: Greg Kurz <address@hidden>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> block/backup.c | 1 +
> block/dirty-bitmap.c | 1 +
> block/file-posix.c | 3 +++
> block/gluster.c | 2 ++
> block/qcow.c | 1 +
> block/qcow2.c | 1 +
> block/vhdx-log.c | 1 +
> block/vpc.c | 1 +
> 8 files changed, 11 insertions(+)
$ git grep -p 'error_append_hint(errp' block/ | grep '\.c=' | wc -l
produces 11 hits, very nicely matching up with your patch.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [PATCH v3 05/25] scripts: add coccinelle script to fix error_append_hint usage, (continued)
- [PATCH v3 05/25] scripts: add coccinelle script to fix error_append_hint usage, Vladimir Sementsov-Ogievskiy, 2019/09/24
- [PATCH v3 04/25] error: auto propagated local_err, Vladimir Sementsov-Ogievskiy, 2019/09/24
- [PATCH v3 24/25] nbd: Fix error_append_hint usage, Vladimir Sementsov-Ogievskiy, 2019/09/24
- [PATCH v3 18/25] block: Fix error_append_hint usage, Vladimir Sementsov-Ogievskiy, 2019/09/24
- Re: [PATCH v3 18/25] block: Fix error_append_hint usage,
Eric Blake <=
- Re: [PATCH v3 00/25] error: auto propagated local_err, no-reply, 2019/09/25