[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC v2 5/9] net/net: fix local variable shadowing in net_client_init
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[RFC v2 5/9] net/net: fix local variable shadowing in net_client_init |
Date: |
Mon, 23 Sep 2019 19:12:27 +0300 |
Don't shadow Error *err: it's a bad thing. This patch also simplifies
following Error propagation conversion.
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
---
net/net.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/net.c b/net/net.c
index 84aa6d8d00..5fc72511c1 100644
--- a/net/net.c
+++ b/net/net.c
@@ -1128,10 +1128,10 @@ static int net_client_init(QemuOpts *opts, bool
is_netdev, Error **errp)
if (substrings[1]) {
/* User-specified prefix length. */
- int err;
+ int ret2;
- err = qemu_strtoul(substrings[1], NULL, 10, &prefix_len);
- if (err) {
+ ret2 = qemu_strtoul(substrings[1], NULL, 10, &prefix_len);
+ if (ret2) {
error_setg(errp, QERR_INVALID_PARAMETER_VALUE,
"ipv6-prefixlen", "a number");
goto out;
--
2.21.0