[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v10 1/9] qapi: group BlockDeviceStats fields
From: |
Anton Nefedov |
Subject: |
[PATCH v10 1/9] qapi: group BlockDeviceStats fields |
Date: |
Mon, 23 Sep 2019 15:17:29 +0300 |
Make the stat fields definition slightly more readable.
Also reorder total_time_ns stats read-write-flush as done elsewhere.
Cosmetic change only.
Signed-off-by: Anton Nefedov <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
---
qapi/block-core.json | 26 +++++++++++++++-----------
1 file changed, 15 insertions(+), 11 deletions(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index e6edd641f1..5ab554b54a 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -867,12 +867,12 @@
# @flush_operations: The number of cache flush operations performed by the
# device (since 0.15.0)
#
-# @flush_total_time_ns: Total time spend on cache flushes in nano-seconds
-# (since 0.15.0).
+# @rd_total_time_ns: Total time spent on reads in nanoseconds (since 0.15.0).
#
-# @wr_total_time_ns: Total time spend on writes in nano-seconds (since 0.15.0).
+# @wr_total_time_ns: Total time spent on writes in nanoseconds (since 0.15.0).
#
-# @rd_total_time_ns: Total_time_spend on reads in nano-seconds (since 0.15.0).
+# @flush_total_time_ns: Total time spent on cache flushes in nanoseconds
+# (since 0.15.0).
#
# @wr_highest_offset: The offset after the greatest byte written to the
# device. The intended use of this information is for
@@ -925,14 +925,18 @@
# Since: 0.14.0
##
{ 'struct': 'BlockDeviceStats',
- 'data': {'rd_bytes': 'int', 'wr_bytes': 'int', 'rd_operations': 'int',
- 'wr_operations': 'int', 'flush_operations': 'int',
- 'flush_total_time_ns': 'int', 'wr_total_time_ns': 'int',
- 'rd_total_time_ns': 'int', 'wr_highest_offset': 'int',
- 'rd_merged': 'int', 'wr_merged': 'int', '*idle_time_ns': 'int',
+ 'data': {'rd_bytes': 'int', 'wr_bytes': 'int',
+ 'rd_operations': 'int', 'wr_operations': 'int',
+ 'flush_operations': 'int',
+ 'rd_total_time_ns': 'int', 'wr_total_time_ns': 'int',
+ 'flush_total_time_ns': 'int',
+ 'wr_highest_offset': 'int',
+ 'rd_merged': 'int', 'wr_merged': 'int',
+ '*idle_time_ns': 'int',
'failed_rd_operations': 'int', 'failed_wr_operations': 'int',
- 'failed_flush_operations': 'int', 'invalid_rd_operations': 'int',
- 'invalid_wr_operations': 'int', 'invalid_flush_operations': 'int',
+ 'failed_flush_operations': 'int',
+ 'invalid_rd_operations': 'int', 'invalid_wr_operations': 'int',
+ 'invalid_flush_operations': 'int',
'account_invalid': 'bool', 'account_failed': 'bool',
'timed_stats': ['BlockDeviceTimedStats'],
'*rd_latency_histogram': 'BlockLatencyHistogramInfo',
--
2.17.1
- [PATCH v10 0/9] discard blockstats, Anton Nefedov, 2019/09/23
- [PATCH v10 7/9] scsi: account unmap operations, Anton Nefedov, 2019/09/23
- [PATCH v10 9/9] qapi: query-blockstat: add driver specific file-posix stats, Anton Nefedov, 2019/09/23
- [PATCH v10 4/9] ide: account UNMAP (TRIM) operations, Anton Nefedov, 2019/09/23
- [PATCH v10 8/9] file-posix: account discard operations, Anton Nefedov, 2019/09/23
- [PATCH v10 2/9] qapi: add unmap to BlockDeviceStats, Anton Nefedov, 2019/09/23
- [PATCH v10 6/9] scsi: move unmap error checking to the complete callback, Anton Nefedov, 2019/09/23
- [PATCH v10 5/9] scsi: store unmap offset and nb_sectors in request struct, Anton Nefedov, 2019/09/23
- [PATCH v10 1/9] qapi: group BlockDeviceStats fields,
Anton Nefedov <=
- [PATCH v10 3/9] block: add empty account cookie type, Anton Nefedov, 2019/09/23
- Re: [PATCH v10 0/9] discard blockstats, Max Reitz, 2019/09/23