[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v4 3/7] iotests: Use case_skip() in skip_if_unsu
From: |
Andrey Shinkevich |
Subject: |
Re: [Qemu-block] [PATCH v4 3/7] iotests: Use case_skip() in skip_if_unsupported() |
Date: |
Tue, 17 Sep 2019 13:00:43 +0000 |
On 17/09/2019 12:20, Max Reitz wrote:
> skip_if_unsupported() should use the stronger variant case_skip(),
> because this allows it to be used even with setUp() (in a meaningful
> way).
>
> In the process, make it explicit what we expect the first argument of
> the func_wrapper to be (namely something derived of QMPTestCase).
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> tests/qemu-iotests/iotests.py | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
> index e46f3b6aed..427c34697a 100644
> --- a/tests/qemu-iotests/iotests.py
> +++ b/tests/qemu-iotests/iotests.py
> @@ -893,14 +893,14 @@ def skip_if_unsupported(required_formats=[],
> read_only=False):
> '''Skip Test Decorator
> Runs the test if all the required formats are whitelisted'''
> def skip_test_decorator(func):
> - def func_wrapper(*args, **kwargs):
> + def func_wrapper(test_case: QMPTestCase, *args, **kwargs):
> usf_list = list(set(required_formats) -
> set(supported_formats(read_only)))
> if usf_list:
> - case_notrun('{}: formats {} are not whitelisted'.format(
> - args[0], usf_list))
> + test_case.case_skip('{}: formats {} are not
> whitelisted'.format(
> + test_case, usf_list))
> else:
> - return func(*args, **kwargs)
> + return func(test_case, *args, **kwargs)
> return func_wrapper
> return skip_test_decorator
>
>
Reviewed-by: Andrey Shinkevich <address@hidden>
--
With the best regards,
Andrey Shinkevich
- [Qemu-block] [PATCH v4 0/7] iotests: Selfish patches, Max Reitz, 2019/09/17
- [Qemu-block] [PATCH v4 1/7] iotests: Prefer null-co over null-aio, Max Reitz, 2019/09/17
- [Qemu-block] [PATCH v4 2/7] iotests: Allow skipping test cases, Max Reitz, 2019/09/17
- [Qemu-block] [PATCH v4 3/7] iotests: Use case_skip() in skip_if_unsupported(), Max Reitz, 2019/09/17
- [Qemu-block] [PATCH v4 4/7] iotests: Let skip_if_unsupported accept a function, Max Reitz, 2019/09/17
- [Qemu-block] [PATCH v4 5/7] iotests: Test driver whitelisting in 093, Max Reitz, 2019/09/17
- Re: [Qemu-block] [Qemu-devel] [PATCH v4 5/7] iotests: Test driver whitelisting in 093, John Snow, 2019/09/18
- [Qemu-block] [PATCH v4 6/7] iotests: Test driver whitelisting in 136, Max Reitz, 2019/09/17