[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH] tests/Makefile: Do not print the n
From: |
John Snow |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH] tests/Makefile: Do not print the name of the check-block.sh shell script |
Date: |
Mon, 9 Sep 2019 12:40:27 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 9/6/19 7:35 AM, Thomas Huth wrote:
> The check script is already printing out which iotest is currently
> running, so printing out the name of the check-block.sh shell script
> looks superfluous here.
>
> Signed-off-by: Thomas Huth <address@hidden>
Makes sense.
Acked-by: John Snow <address@hidden>
> ---
> tests/Makefile.include | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index f5ac09549c..a36317ac87 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -1097,7 +1097,7 @@ QEMU_IOTESTS_HELPERS-$(call
> land,$(CONFIG_SOFTMMU),$(CONFIG_LINUX)) = tests/qemu
> check-tests/check-block.sh: tests/check-block.sh qemu-img$(EXESUF) \
> qemu-io$(EXESUF) qemu-nbd$(EXESUF) $(QEMU_IOTESTS_HELPERS-y) \
> $(patsubst %,%/all,$(filter %-softmmu,$(TARGET_DIRS)))
> - $<
> + @$<
>
> .PHONY: $(patsubst %, check-%, $(check-qapi-schema-y))
> $(patsubst %, check-%, $(check-qapi-schema-y)): check-%.json:
> $(SRC_PATH)/%.json
>