[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v2 4/5] iotests: Restrict nbd Python tests to nbd
From: |
Max Reitz |
Subject: |
[Qemu-block] [PATCH v2 4/5] iotests: Restrict nbd Python tests to nbd |
Date: |
Mon, 2 Sep 2019 21:33:19 +0200 |
We have two Python unittest-style tests that test NBD. As such, they
should specify supported_protocols=['nbd'] so they are skipped when the
user wants to test some other protocol.
Furthermore, we should restrict their choice of formats to 'raw'. The
idea of a protocol/format combination is to use some format over some
protocol; but we always use the raw format over NBD. It does not really
matter what the NBD server uses on its end, and it is not a useful test
of the respective format driver anyway.
Signed-off-by: Max Reitz <address@hidden>
---
tests/qemu-iotests/147 | 5 ++---
tests/qemu-iotests/205 | 3 ++-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/qemu-iotests/147 b/tests/qemu-iotests/147
index 2d84fddb01..ab8480b9a4 100755
--- a/tests/qemu-iotests/147
+++ b/tests/qemu-iotests/147
@@ -287,6 +287,5 @@ class BuiltinNBD(NBDBlockdevAddBase):
if __name__ == '__main__':
- # Need to support image creation
- iotests.main(supported_fmts=['vpc', 'parallels', 'qcow', 'vdi', 'qcow2',
- 'vmdk', 'raw', 'vhdx', 'qed'])
+ iotests.main(supported_fmts=['raw'],
+ supported_protocols=['nbd'])
diff --git a/tests/qemu-iotests/205 b/tests/qemu-iotests/205
index b8a86c446e..76f6c5fa2b 100755
--- a/tests/qemu-iotests/205
+++ b/tests/qemu-iotests/205
@@ -153,4 +153,5 @@ class TestNbdServerRemove(iotests.QMPTestCase):
if __name__ == '__main__':
- iotests.main(supported_fmts=['generic'])
+ iotests.main(supported_fmts=['raw'],
+ supported_protocols=['nbd'])
--
2.21.0
- [Qemu-block] [PATCH v2 0/5] vpc: Return 0 from vpc_co_create() on success, Max Reitz, 2019/09/02
- [Qemu-block] [PATCH v2 1/5] vpc: Return 0 from vpc_co_create() on success, Max Reitz, 2019/09/02
- [Qemu-block] [PATCH v2 2/5] iotests: Add supported protocols to execute_test(), Max Reitz, 2019/09/02
- [Qemu-block] [PATCH v2 3/5] iotests: Restrict file Python tests to file, Max Reitz, 2019/09/02
- [Qemu-block] [PATCH v2 4/5] iotests: Restrict nbd Python tests to nbd,
Max Reitz <=
- [Qemu-block] [PATCH v2 5/5] iotests: Test blockdev-create for vpc, Max Reitz, 2019/09/02
- Re: [Qemu-block] [PATCH v2 0/5] vpc: Return 0 from vpc_co_create() on success, Kevin Wolf, 2019/09/03