[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v3 4/7] iotests: Valgrind fails with nonexistent dir
From: |
Andrey Shinkevich |
Subject: |
[Qemu-block] [PATCH v3 4/7] iotests: Valgrind fails with nonexistent directory |
Date: |
Fri, 28 Jun 2019 16:46:11 +0300 |
The Valgrind uses the exported variable TMPDIR and fails if the
directory does not exist. Let us exclude such a test case from
being run under the Valgrind and notify the user of it.
Suggested-by: Kevin Wolf <address@hidden>
Signed-off-by: Andrey Shinkevich <address@hidden>
---
tests/qemu-iotests/051 | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051
index 200660f..2465e48 100755
--- a/tests/qemu-iotests/051
+++ b/tests/qemu-iotests/051
@@ -377,6 +377,10 @@ printf %b "qemu-io $device_id \"write -P 0x33 0
4k\"\ncommit $device_id\n" |
$QEMU_IO -c "read -P 0x33 0 4k" "$TEST_IMG" | _filter_qemu_io
# Using snapshot=on with a non-existent TMPDIR
+if [ "${VALGRIND_QEMU}" == "y" ]; then
+ _casenotrun "Valgrind needs a valid TMPDIR for itself"
+fi
+VALGRIND_QEMU="" \
TMPDIR=/nonexistent run_qemu -drive driver=null-co,snapshot=on
# Using snapshot=on together with read-only=on
--
1.8.3.1
- [Qemu-block] [PATCH v3 0/7] Allow Valgrind checking all QEMU processes, Andrey Shinkevich, 2019/06/28
- [Qemu-block] [PATCH v3 2/7] iotests: exclude killed processes from running under Valgrind, Andrey Shinkevich, 2019/06/28
- [Qemu-block] [PATCH v3 4/7] iotests: Valgrind fails with nonexistent directory,
Andrey Shinkevich <=
- [Qemu-block] [PATCH v3 6/7] iotests: extend sleeping time under Valgrind, Andrey Shinkevich, 2019/06/28
- [Qemu-block] [PATCH v3 7/7] iotests: Set read-zeroes on in null block driver for Valgrind, Andrey Shinkevich, 2019/06/28
- [Qemu-block] [PATCH v3 3/7] iotests: Add casenotrun report to bash tests, Andrey Shinkevich, 2019/06/28
- [Qemu-block] [PATCH v3 5/7] iotests: extended timeout under Valgrind, Andrey Shinkevich, 2019/06/28
- [Qemu-block] [PATCH v3 1/7] iotests: allow Valgrind checking all QEMU processes, Andrey Shinkevich, 2019/06/28