[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 0/2] nbd: enable keepalive
From: |
John Snow |
Subject: |
Re: [Qemu-block] [PATCH v2 0/2] nbd: enable keepalive |
Date: |
Wed, 26 Jun 2019 17:18:31 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 6/5/19 12:18 PM, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
>
> Here is a suggestion to enable keepalive option to track server availablity.
> We suggest to enable it by default. If we need, we'll be able to add option
> to specify timeout by hand later.
>
> v2: 01 - Fix io channel returned errors to be -1 [Daniel]
> 02 - Fix typo in commit message [Eric]
>
> Vladimir Sementsov-Ogievskiy (2):
> io/channel: add qio_channel_set_keepalive
> nbd-client: enable TCP keepalive
>
> include/io/channel.h | 15 +++++++++++++++
> block/nbd-client.c | 1 +
> io/channel-socket.c | 20 ++++++++++++++++++++
> io/channel.c | 14 ++++++++++++++
> 4 files changed, 50 insertions(+)
>
Ping -- I think this was good to go with Dan's ACK, based on the
discussion from v1.