[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 08/12] iotests: add testing shim for script-styl
From: |
John Snow |
Subject: |
Re: [Qemu-block] [PATCH 08/12] iotests: add testing shim for script-style python tests |
Date: |
Thu, 20 Jun 2019 14:47:59 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 6/20/19 1:26 PM, Max Reitz wrote:
> On 20.06.19 19:09, Max Reitz wrote:
>> On 20.06.19 03:03, John Snow wrote:
>>> Because the new-style python tests don't use the iotests.main() test
>>> launcher, we don't turn on the debugger logging for these scripts
>>> when invoked via ./check -d.
>>>
>>> Refactor the launcher shim into new and old style shims so that they
>>> share environmental configuration.
>>>
>>> Two cleanup notes: debug was not actually used as a global, and there
>>> was no reason to create a class in an inner scope just to achieve
>>> default variables; we can simply create an instance of the runner with
>>> the values we want instead.
>>>
>>> Signed-off-by: John Snow <address@hidden>
>>> ---
>>> tests/qemu-iotests/iotests.py | 40 +++++++++++++++++++++++------------
>>> 1 file changed, 26 insertions(+), 14 deletions(-)
>>
>> I don’t quite get how script_main() works (yes, both my Pythonfu and my
>> Googlefu are that bad), but it works and looks good, so have a
>
> Oh, it doesn’t work (well, not automagically). I just assumed seeing
> the log output means it’s working. Seeing that the test needs to call
> iotests.script_main() explicitly does clear up my confusion.
>
> All OK with me.
>
> Max
>
Yes. I should convert the others to opt-in to the new format so that
copy-paste in the future will get us the right paradigm.
Tests just need to be refactored to have a single point of entry so it
can be passed as a closure to the test runner.
If this seems like a good change I will do that as a follow-up series
with only the churn.
--js
[Qemu-block] [PATCH 05/12] hbitmap: enable merging across granularities, John Snow, 2019/06/19
[Qemu-block] [PATCH 11/12] iotests: add test 257 for bitmap-mode backups, John Snow, 2019/06/19