[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [SeaBIOS] [QEMU] [PATCH v4 0/8] Add Qemu to SeaBIOS LCH
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-block] [SeaBIOS] [QEMU] [PATCH v4 0/8] Add Qemu to SeaBIOS LCHS interface |
Date: |
Thu, 20 Jun 2019 07:50:38 +0200 |
User-agent: |
NeoMutt/20180716 |
> === OUTPUT BEGIN ===
> 1/8 Checking commit cf2168a66dbd (block: Refactor macros - fix tabbing)
> ERROR: Macros with complex values should be enclosed in parenthesis
> #55: FILE: include/hw/block/block.h:65:
> +#define DEFINE_BLOCK_CHS_PROPERTIES(_state, _conf) \
> + DEFINE_PROP_UINT32("cyls", _state, _conf.cyls, 0), \
> + DEFINE_PROP_UINT32("heads", _state, _conf.heads, 0), \
> DEFINE_PROP_UINT32("secs", _state, _conf.secs, 0)
False positive.
> 8/8 Checking commit 6664d7d898d5 (hd-geo-test: Add tests for lchs override)
> WARNING: line over 80 characters
> #242: FILE: tests/hd-geo-test.c:579:
> + (char *)r->dev_path, &(r->chs.c), &(r->chs.h),
> &(r->chs.s));
Should be fixed.
> WARNING: Block comments use a leading /* on a separate line
> #640: FILE: tests/hd-geo-test.c:995:
> + "skipping hd-geo/override/* tests");
False positive too.
cheers,
Gerd
- [Qemu-block] [QEMU] [PATCH v4 2/8] block: Support providing LCHS from user, (continued)
- [Qemu-block] [QEMU] [PATCH v4 2/8] block: Support providing LCHS from user, Sam Eiderman, 2019/06/19
- [Qemu-block] [QEMU] [PATCH v4 3/8] bootdevice: Add interface to gather LCHS, Sam Eiderman, 2019/06/19
- [Qemu-block] [QEMU] [PATCH v4 1/8] block: Refactor macros - fix tabbing, Sam Eiderman, 2019/06/19
- [Qemu-block] [QEMU] [PATCH v4 5/8] bootdevice: Gather LCHS from all relevant devices, Sam Eiderman, 2019/06/19
- [Qemu-block] [QEMU] [PATCH v4 8/8] hd-geo-test: Add tests for lchs override, Sam Eiderman, 2019/06/19
- [Qemu-block] [QEMU] [PATCH v4 6/8] bootdevice: Refactor get_boot_devices_list, Sam Eiderman, 2019/06/19
- [Qemu-block] [QEMU] [PATCH v4 4/8] scsi: Propagate unrealize() callback to scsi-hd, Sam Eiderman, 2019/06/19
- [Qemu-block] [QEMU] [PATCH v4 7/8] bootdevice: FW_CFG interface for LCHS values, Sam Eiderman, 2019/06/19
- Re: [Qemu-block] [SeaBIOS] [QEMU] [PATCH v4 0/8] Add Qemu to SeaBIOS LCHS interface, no-reply, 2019/06/19
- Re: [Qemu-block] [SeaBIOS] [QEMU] [PATCH v4 0/8] Add Qemu to SeaBIOS LCHS interface,
Gerd Hoffmann <=
- Re: [Qemu-block] [SeaBIOS] [QEMU] [PATCH v4 0/8] Add Qemu to SeaBIOS LCHS interface, no-reply, 2019/06/19
- Re: [Qemu-block] [SeaBIOS] [QEMU] [PATCH v4 0/8] Add Qemu to SeaBIOS LCHS interface, no-reply, 2019/06/19