[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH 10/12] iotests: teach FilePath to produce multiple p
From: |
John Snow |
Subject: |
[Qemu-block] [PATCH 10/12] iotests: teach FilePath to produce multiple paths |
Date: |
Wed, 19 Jun 2019 21:03:54 -0400 |
Use "FilePaths" instead of "FilePath" to request multiple files be
cleaned up after we leave that object's scope.
This is not crucial; but it saves a little typing.
Signed-off-by: John Snow <address@hidden>
---
tests/qemu-iotests/iotests.py | 21 +++++++++++++++------
1 file changed, 15 insertions(+), 6 deletions(-)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index c544659ecb..b938fa9719 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -359,7 +359,7 @@ class Timeout:
raise Exception(self.errmsg)
-class FilePath(object):
+class FilePaths(object):
'''An auto-generated filename that cleans itself up.
Use this context manager to generate filenames and ensure that the file
@@ -369,20 +369,29 @@ class FilePath(object):
qemu_img('create', img_path, '1G')
# migration_sock_path is automatically deleted
'''
- def __init__(self, name):
- filename = '{0}-{1}'.format(os.getpid(), name)
- self.path = os.path.join(test_dir, filename)
+ def __init__(self, names):
+ self.paths = []
+ for name in names:
+ filename = '{0}-{1}'.format(os.getpid(), name)
+ self.paths.append(os.path.join(test_dir, filename))
def __enter__(self):
- return self.path
+ return self.paths
def __exit__(self, exc_type, exc_val, exc_tb):
try:
- os.remove(self.path)
+ for path in self.paths:
+ os.remove(path)
except OSError:
pass
return False
+class FilePath(FilePaths):
+ def __init__(self, name):
+ super(FilePath, self).__init__([name])
+
+ def __enter__(self):
+ return self.paths[0]
def file_path_remover():
for path in reversed(file_path_remover.paths):
--
2.21.0
- Re: [Qemu-block] [PATCH 07/12] block/backup: add 'always' bitmap sync policy, (continued)
- Re: [Qemu-block] [PATCH 07/12] block/backup: add 'always' bitmap sync policy, Vladimir Sementsov-Ogievskiy, 2019/06/21
- Re: [Qemu-block] [PATCH 07/12] block/backup: add 'always' bitmap sync policy, Vladimir Sementsov-Ogievskiy, 2019/06/21
- Re: [Qemu-block] [PATCH 07/12] block/backup: add 'always' bitmap sync policy, Vladimir Sementsov-Ogievskiy, 2019/06/21
- Re: [Qemu-block] [PATCH 07/12] block/backup: add 'always' bitmap sync policy, Vladimir Sementsov-Ogievskiy, 2019/06/21
- Re: [Qemu-block] [Qemu-devel] [PATCH 07/12] block/backup: add 'always' bitmap sync policy, John Snow, 2019/06/21
- Re: [Qemu-block] [Qemu-devel] [PATCH 07/12] block/backup: add 'always' bitmap sync policy, Max Reitz, 2019/06/21
- Re: [Qemu-block] [Qemu-devel] [PATCH 07/12] block/backup: add 'always' bitmap sync policy, John Snow, 2019/06/21
[Qemu-block] [PATCH 10/12] iotests: teach FilePath to produce multiple paths,
John Snow <=
[Qemu-block] [PATCH 06/12] block/dirty-bitmap: add bdrv_dirty_bitmap_claim, John Snow, 2019/06/19
[Qemu-block] [PATCH 04/12] hbitmap: Fix merge when b is empty, and result is not an alias of a, John Snow, 2019/06/19
[Qemu-block] [PATCH 01/12] qapi: add BitmapSyncMode enum, John Snow, 2019/06/19