[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH] iotests: Fix 205 for concurrent ru
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH] iotests: Fix 205 for concurrent runs |
Date: |
Tue, 18 Jun 2019 16:09:35 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 6/18/19 4:02 PM, Max Reitz wrote:
> Tests should place their files into the test directory. This includes
> Unix sockets. 205 currently fails to do so, which prevents it from
> being run concurrently.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> tests/qemu-iotests/205 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
Feel free to take this through your iotests tree, but I can also stage
it through my NBD tree if I haven't seen it go in by the time of my next
pull request.
>
> diff --git a/tests/qemu-iotests/205 b/tests/qemu-iotests/205
> index 69f2c1d392..b8a86c446e 100755
> --- a/tests/qemu-iotests/205
> +++ b/tests/qemu-iotests/205
> @@ -24,7 +24,7 @@ import iotests
> import time
> from iotests import qemu_img_create, qemu_io, filter_qemu_io,
> QemuIoInteractive
>
> -nbd_sock = 'nbd_sock'
> +nbd_sock = os.path.join(iotests.test_dir, 'nbd_sock')
> nbd_uri = 'nbd+unix:///exp?socket=' + nbd_sock
> disk = os.path.join(iotests.test_dir, 'disk')
>
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature