[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v5 10/12] block/io_uring: adds userspace complet
From: |
Maxim Levitsky |
Subject: |
Re: [Qemu-block] [PATCH v5 10/12] block/io_uring: adds userspace completion polling |
Date: |
Mon, 17 Jun 2019 17:14:31 +0300 |
On Tue, 2019-06-11 at 10:51 +0100, Stefan Hajnoczi wrote:
> On Mon, Jun 10, 2019 at 07:19:03PM +0530, Aarushi Mehta wrote:
> > +static bool qemu_luring_poll_cb(void *opaque)
> > +{
> > + LuringState *s = opaque;
> > + struct io_uring_cqe *cqes;
> > +
> > + if (io_uring_peek_cqe(&s->ring, &cqes) == 0) {
> > + if (!cqes) {
> > + qemu_luring_process_completions_and_submit(s);
> > + return true;
> > + }
>
> Is this logic inverted? We have a completion when cqes != NULL.
This indeed looks inverted to me.
Best regards,
Maxim Levitsky
- Re: [Qemu-block] [PATCH v5 07/12] blockdev: accept io_uring as option, (continued)
[Qemu-block] [PATCH v5 09/12] block: add trace events for io_uring, Aarushi Mehta, 2019/06/10
[Qemu-block] [PATCH v5 08/12] block/file-posix.c: extend to use io_uring, Aarushi Mehta, 2019/06/10
[Qemu-block] [PATCH v5 10/12] block/io_uring: adds userspace completion polling, Aarushi Mehta, 2019/06/10
[Qemu-block] [PATCH v5 11/12] qemu-io: adds support for io_uring, Aarushi Mehta, 2019/06/10
[Qemu-block] [PATCH v5 12/12] qemu-iotests/087: checks for io_uring, Aarushi Mehta, 2019/06/10
Re: [Qemu-block] [PATCH v5 00/12] Add support for io_uring, Stefan Hajnoczi, 2019/06/11