[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [RFC PATCH 10/10] monitor: Split out monitor/core.c
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-block] [RFC PATCH 10/10] monitor: Split out monitor/core.c |
Date: |
Tue, 11 Jun 2019 10:25:51 +0100 |
User-agent: |
Mutt/1.11.4 (2019-03-13) |
* Kevin Wolf (address@hidden) wrote:
> Am 07.06.2019 um 19:29 hat Dr. David Alan Gilbert geschrieben:
> > * Kevin Wolf (address@hidden) wrote:
> > > Move the monitor core infrastructure from monitor/misc.c to
> > > monitor/core.c. This is code that can be shared for all targets, so
> > > compile it only once.
> > >
> > > What remains in monitor/misc.c after this patch is mostly monitor
> > > command implementations and code that requires a system emulator or is
> > > even target-dependent.
> > >
> > > The amount of function and particularly extern variables in
> > > monitor_int.h is probably a bit larger than it needs to be, but this way
> > > no non-trivial code modifications are needed. The interfaces between all
> > > monitor parts can be cleaned up later.
> > >
> > > Signed-off-by: Kevin Wolf <address@hidden>
> >
> > OK, but can you call it anything other than core.* - I regularly end up
> > deleting things like that!
>
> Oh, I didn't even think of this kind of core.*!
>
> I imagine in practice it wouldn't be so bad to have a monitor/core.c
> because it's in a subdirectory, and it's under version control anyway.
> We already seem to have quite a few of them in subdirectories:
>
> ./hw/acpi/core.c
> ./hw/bt/core.c
> ./hw/cpu/core.c
> ./hw/i2c/core.c
> ./hw/ide/core.c
> ./hw/sd/core.c
> ./hw/usb/core.c
Yes, they all annoy me in the same way :-)
> But I'll gladly rename it if I can find a good name. Do you have any
> suggestions? Maybe just monitor/monitor.c?
Yes that's fine, thanks!
Dave
> Kevin
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- Re: [Qemu-block] [RFC PATCH 06/10] Move monitor.c to monitor/misc.c, (continued)
- [Qemu-block] [RFC PATCH 07/10] monitor: Create monitor_int.h with common definitions, Kevin Wolf, 2019/06/07
- [Qemu-block] [RFC PATCH 08/10] monitor: Split out monitor/qmp.c, Kevin Wolf, 2019/06/07
- [Qemu-block] [RFC PATCH 03/10] monitor: Make MonitorQMP a child class of Monitor, Kevin Wolf, 2019/06/07
- [Qemu-block] [RFC PATCH 10/10] monitor: Split out monitor/core.c, Kevin Wolf, 2019/06/07
- Re: [Qemu-block] [RFC PATCH 10/10] monitor: Split out monitor/core.c, Dr. David Alan Gilbert, 2019/06/07
- [Qemu-block] [RFC PATCH 09/10] monitor: Split out monitor/hmp.c, Kevin Wolf, 2019/06/07
- Re: [Qemu-block] [Qemu-devel] [RFC PATCH 00/10] monitor: Split monitor.c in core/HMP/QMP/misc, Daniel P . Berrangé, 2019/06/07
Re: [Qemu-block] [Qemu-devel] [RFC PATCH 00/10] monitor: Split monitor.c in core/HMP/QMP/misc, no-reply, 2019/06/07
Re: [Qemu-block] [Qemu-devel] [RFC PATCH 00/10] monitor: Split monitor.c in core/HMP/QMP/misc, no-reply, 2019/06/07