[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 1/5] block/qcow2-bitmap: allow bitmap_list_load
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH 1/5] block/qcow2-bitmap: allow bitmap_list_load to return an error code |
Date: |
Thu, 6 Jun 2019 21:07:35 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 6/6/19 1:41 PM, John Snow wrote:
> This simply makes this function a little more convenient to call, and in
> a forthcoming patch gives us a return code we can report to the
> caller. (Which in turn makes THOSE functions easier to call.)
>
> While we're here, remove the offset+size arguments which are only ever
> called with the same values that can be determined inside this helper.
>
> Signed-off-by: John Snow <address@hidden>
> ---
> block/qcow2-bitmap.c | 64 +++++++++++++++++++-------------------------
> 1 file changed, 28 insertions(+), 36 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature