[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v5 0/3] Fix overflow bug in qcow2 discard
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
Re: [Qemu-block] [PATCH v5 0/3] Fix overflow bug in qcow2 discard |
Date: |
Mon, 3 Jun 2019 13:52:17 +0000 |
03.06.2019 16:40, Kevin Wolf wrote:
> Am 23.04.2019 um 14:57 hat Vladimir Sementsov-Ogievskiy geschrieben:
>> v5: by Kevin's comments
>> 02: add check for invalid @bytes parameter, drop r-b
>> 03: move from qemu-img info to qemu-img map -f raw, drop r-b and t-b
>
> The patches look good to me, but the test case fails (this is on XFS; it
> does work on tmpfs):
>
> --- /home/kwolf/source/qemu/tests/qemu-iotests/250.out 2019-06-03
> 15:22:51.212961123 +0200
> +++ /home/kwolf/source/qemu/tests/qemu-iotests/250.out.bad 2019-06-03
> 15:37:37.202959101 +0200
> @@ -12,12 +12,10 @@
> 0 0xa00000 0x82f00000 TEST_DIR/t.qcow2
> 0x82a00000 0xa00000 0x500000 TEST_DIR/t.qcow2
> Offset Length Mapped to File
> -0 0x301000 0 TEST_DIR/t.qcow2
> -0x400000 0xb00000 0x400000 TEST_DIR/t.qcow2
> +0 0xf00000 0 TEST_DIR/t.qcow2
> 0x82f00000 0xa00000 0x82f00000 TEST_DIR/t.qcow2
> Image resized.
> Offset Length Mapped to File
> -0 0x301000 0 TEST_DIR/t.qcow2
> -0x400000 0x100000 0x400000 TEST_DIR/t.qcow2
> +0 0x500000 0 TEST_DIR/t.qcow2
> 0x82f00000 0x500000 0x82f00000 TEST_DIR/t.qcow2
> *** done
>
> I'll apply the first two patches without the test for now, but please
> try if you can tweak the test case to work on all common filesystems.
>
> Kevin
>
Thank you! OK, I'll try
--
Best regards,
Vladimir