[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v6 5/5] block/backup: refactor: split out backup
|
From: |
Vladimir Sementsov-Ogievskiy |
|
Subject: |
Re: [Qemu-block] [PATCH v6 5/5] block/backup: refactor: split out backup_calculate_cluster_size |
|
Date: |
Mon, 29 Apr 2019 04:49:56 +0000 |
26.04.2019 21:30, Max Reitz wrote:
> On 15.04.19 16:49, Vladimir Sementsov-Ogievskiy wrote:
>> Split out cluster_size calculation. Move copy-bitmap creation above
>> block-job creation, as we are going to share it with upcoming
>> backup-top filter, which also should be created before actual block job
>> creation.
>>
>> Also, while being here, drop unnecessary "goto error" from
>> bdrv_getlength error path.
>
> It isn’t unnecessary, though. Before this, we invoke
> bdrv_dirty_bitmap_create_successor(), so the error path has to clean
> that up with bdrv_reclaim_dirty_bitmap().
>
> Max
>
Oops, will resend. I was looking at previous plain "return NULL", but missed
that in "if" branch we do thing to be rolled-back on fail.
Thank you for review!
--
Best regards,
Vladimir
- [Qemu-block] [PATCH v6 0/5] backup-top: preparing refactoring, Vladimir Sementsov-Ogievskiy, 2019/04/15
- [Qemu-block] [PATCH v6 3/5] block/backup: refactor and tolerate unallocated cluster skipping, Vladimir Sementsov-Ogievskiy, 2019/04/15
- [Qemu-block] [PATCH v6 5/5] block/backup: refactor: split out backup_calculate_cluster_size, Vladimir Sementsov-Ogievskiy, 2019/04/15
- [Qemu-block] [PATCH v6 4/5] block/backup: unify different modes code path, Vladimir Sementsov-Ogievskiy, 2019/04/15
- [Qemu-block] [PATCH v6 2/5] block/backup: move to copy_bitmap with granularity, Vladimir Sementsov-Ogievskiy, 2019/04/15
- [Qemu-block] [PATCH v6 1/5] block/backup: simplify backup_incremental_init_copy_bitmap, Vladimir Sementsov-Ogievskiy, 2019/04/15