[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 5/6] tests: Run the iotests during
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 5/6] tests: Run the iotests during "make check" again |
Date: |
Sat, 27 Apr 2019 21:42:43 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 4/25/19 5:24 AM, Thomas Huth wrote:
>> Ok, thanks for the info. Looks like many tests are failing because qemu-io
>> suddenly prints its program name in front of the error messages? E.g.:
>>
>> --- /tmp/qemu-test/src/tests/qemu-iotests/069.out 2019-04-24
>> 16:52:31.000000000 +0000
>> +++ /tmp/qemu-test/build/tests/qemu-iotests/069.out.bad 2019-04-24
>> 16:59:13.310226424 +0000
>> @@ -4,5 +4,5 @@
>>
>> Formatting 'TEST_DIR/t.IMGFMT.base', fmt=IMGFMT size=131072
>> Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=131072
>> backing_file=TEST_DIR/t.IMGFMT.base
>> -can't open device TEST_DIR/t.IMGFMT: Could not open backing file: Could not
>> open 'TEST_DIR/t.IMGFMT.base': No such file or directory
>> +qemu-io: can't open device TEST_DIR/t.IMGFMT: Could not open backing file:
>> Could not open 'TEST_DIR/t.IMGFMT.base': No such file or directory
>>
>> Does anybody from the block folks has a clue what might be going wrong here?
>
> It's a regression in the current master branch, not caused by my series.
> The iotests also fail with vanilla master, e.g. reproducible with:
>
> cd tests/qemu-iotests
> ./check -qcow2 069
>
> It's caused by Christophe's commit here:
>
> 99e98d7c9fc1a1639fad2c638733b02f4b43aebe
> qemu-io: Use error_[gs]et_progname()
>
> Christophe, could you please have a look?
The change in output is desirable, but yes, it does mean that iotests
need to have .out files updated to match.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [Qemu-devel] [PATCH 2/6] tests/qemu-iotests/group: Introduce a new "ci" group for CI pipelines, (continued)
Re: [Qemu-block] [Qemu-devel] [PATCH 5/6] tests: Run the iotests during "make check" again, Wainer dos Santos Moschetta, 2019/04/24
[Qemu-block] [PATCH 6/6] tests/qemu-iotests: Remove the "_supported_os Linux" line from many tests, Thomas Huth, 2019/04/24
Re: [Qemu-block] [Qemu-devel] [PATCH 0/6] tests/qemu-iotests: Run basic iotests during "make check", no-reply, 2019/04/27
Re: [Qemu-block] [Qemu-devel] [PATCH 0/6] tests/qemu-iotests: Run basic iotests during "make check", Christian Borntraeger, 2019/04/29