[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v4 07/10] block/pflash_cfi02: Fix reset command not
From: |
Stephen Checkoway |
Subject: |
[Qemu-block] [PATCH v4 07/10] block/pflash_cfi02: Fix reset command not ignored during erase |
Date: |
Fri, 26 Apr 2019 12:26:21 -0400 |
When the flash device is performing a chip erase, all commands are
ignored. When it is performing a sector erase, only the erase suspend
command is valid, which is currently not supported.
In particular, the reset command should not cause the device to reset to
read array mode while programming is on going.
Signed-off-by: Stephen Checkoway <address@hidden>
---
hw/block/pflash_cfi02.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c
index be10036886..cb1160eb35 100644
--- a/hw/block/pflash_cfi02.c
+++ b/hw/block/pflash_cfi02.c
@@ -325,7 +325,8 @@ static void pflash_write(void *opaque, hwaddr offset,
uint64_t value,
pfl->bank_width * 2, value);
}
- if (cmd == 0xF0) {
+ /* Reset does nothing during chip erase and sector erase. */
+ if (cmd == 0xF0 && pfl->cmd != 0x10 && pfl->cmd != 0x30) {
if (pfl->wcycle == WCYCLE_AUTOSELECT_CFI) {
/* Return to autoselect mode. */
pfl->wcycle = 3;
--
2.20.1 (Apple Git-117)
- [Qemu-block] [PATCH v4 00/10] block/pflash_cfi02: Implement missing AMD pflash functionality, Stephen Checkoway, 2019/04/26
- [Qemu-block] [PATCH v4 03/10] block/pflash_cfi02: Fix command address comparison, Stephen Checkoway, 2019/04/26
- [Qemu-block] [PATCH v4 02/10] block/pflash_cfi02: Refactor, NFC intended, Stephen Checkoway, 2019/04/26
- [Qemu-block] [PATCH v4 01/10] block/pflash_cfi02: Add test for supported commands, Stephen Checkoway, 2019/04/26
- [Qemu-block] [PATCH v4 06/10] block/pflash_cfi02: Fix CFI in autoselect mode, Stephen Checkoway, 2019/04/26
- [Qemu-block] [PATCH v4 05/10] block/pflash_cfi02: Implement nonuniform sector sizes, Stephen Checkoway, 2019/04/26
- [Qemu-block] [PATCH v4 07/10] block/pflash_cfi02: Fix reset command not ignored during erase,
Stephen Checkoway <=
- [Qemu-block] [PATCH v4 10/10] block/pflash_cfi02: Use the chip erase time specified in the CFI table, Stephen Checkoway, 2019/04/26
- [Qemu-block] [PATCH v4 04/10] block/pflash_cfi02: Implement intereleaved flash devices, Stephen Checkoway, 2019/04/26
- [Qemu-block] [PATCH v4 09/10] block/pflash_cfi02: Implement erase suspend/resume, Stephen Checkoway, 2019/04/26
- [Qemu-block] [PATCH v4 08/10] block/pflash_cfi02: Implement multi-sector erase, Stephen Checkoway, 2019/04/26