[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 1/3] qemu-img: Allow rebase with no
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 1/3] qemu-img: Allow rebase with no input base |
Date: |
Wed, 24 Apr 2019 15:38:54 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 18.04.19 20:55, Eric Blake wrote:
> On 7/13/18 6:14 AM, Max Reitz wrote:
>> Currently, you cannot add a backing file to an image when it currently
>> has none. It is really simple to allow this, though (effectively by
>> setting old_backing_size to 0), so this patch does just that.
>
> Can't you do that with 'rebase -u'? I guess the point of this patch is
> to make 'rebase' without -u also able to add a backing file? A bit more
> clarity in the commit message, such as a sample command line (and
> possibly even the error it issued pre-patch) would help.
Yes, this is about normal rebase without -u.
There is an example in the cover letter, but I can add it to this patch
here, too, yes.
>> Signed-off-by: Max Reitz <address@hidden>
>> ---
>> qemu-img.c | 61 ++++++++++++++++++++++++++++++------------------------
>> 1 file changed, 34 insertions(+), 27 deletions(-)
>
> At any rate, the code looks fine, even if the diff is harder to read
> because of added indentation.
>
> Reviewed-by: Eric Blake <address@hidden>
Thanks!
Max
signature.asc
Description: OpenPGP digital signature