[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 01/10] block/pflash_cfi02: Add test for suppo
From: |
Thomas Huth |
Subject: |
Re: [Qemu-block] [PATCH v3 01/10] block/pflash_cfi02: Add test for supported commands |
Date: |
Fri, 19 Apr 2019 07:57:59 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
Hi,
On 18/04/2019 22.43, Stephen Checkoway wrote:
[...]
> I'm new to contributing to QEMU and I have a two procedural questions:
>
> 1. When should I send version 4 of this patch series? I don't want to bombard
> everyone with another 11 emails after fixing every review comment, but I also
> don't want to let the patch linger without addressing comments.
There is no hard rule ... I normally wait for a day or two before
sending another iteration, to see whether there are any further comments.
> 2. I'm not familiar with the "Acked-by" convention. I read
> <https://www.kernel.org/doc/html/v4.16/process/submitting-patches.html#when-to-use-acked-by-and-cc>.
> Am I supposed to add those to the commit messages or do those get added by
> whomever actually includes the patch in the main QEMU repo?
I assume that the patches will go in via the block tree (or another
one), so I used Acked-by here to say that I've seen the patches and I'm
basically fine with them from the qtests perspective (since I'm listed
as qtests maintainer).
When you send another iteration, you should add the "Acked-by" lines on
your own, so that the information does not get lost in v4. (But when you
sent the final iteration, and there are more Acked-by/Reviewed-by reply
mails to that series, it's up to the maintainers to pick up these lines
when including the patches to their tree.)
Thomas
- [Qemu-block] [PATCH v3 00/10] block/pflash_cfi02: Implement missing AMD pflash functionality, Stephen Checkoway, 2019/04/17
- [Qemu-block] [PATCH v3 03/10] block/pflash_cfi02: Fix command address comparison, Stephen Checkoway, 2019/04/17
- [Qemu-block] [PATCH v3 02/10] block/pflash_cfi02: Refactor, NFC intended, Stephen Checkoway, 2019/04/17
- [Qemu-block] [PATCH v3 06/10] block/pflash_cfi02: Fix CFI in autoselect mode, Stephen Checkoway, 2019/04/17
- [Qemu-block] [PATCH v3 07/10] block/pflash_cfi02: Fix reset command not ignored during erase, Stephen Checkoway, 2019/04/17
- [Qemu-block] [PATCH v3 08/10] block/pflash_cfi02: Implement multi-sector erase, Stephen Checkoway, 2019/04/17
- [Qemu-block] [PATCH v3 05/10] block/pflash_cfi02: Implement nonuniform sector sizes, Stephen Checkoway, 2019/04/17