[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] scsi-generic: prevent guest from exceeding SG_I
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-block] [PATCH] scsi-generic: prevent guest from exceeding SG_IO limits |
|
Date: |
Thu, 18 Apr 2019 13:01:17 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 18/04/19 12:47, Kevin Wolf wrote:
>> This is acually only an issue with kernels prior to 4.5, so it should be
>> fixed downstream instead.
>
> I don't think that upstream QEMU has kernels > 4.5 as an official
> requirement, though? We try to be compatible with quite old libs, so we
> should stay compatible with old kernels, too.
It is a pretty rare case, where the host must support very large
scatter/gather lists (>=1024 elements) and there is a workaround by
setting max_sectors_kb to 4096 in the host. It also makes performance
worse.
Having already written and posted the patch, I can of course apply it
too, but I'm not sure it's a good idea. 4.4 is already a pretty old
kernel and whoever is using it likely will not get the fix for free by
using a very new QEMU.
Paolo