[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 05/10] block/pflash_cfi02: Implement nonunifo
From: |
Thomas Huth |
Subject: |
Re: [Qemu-block] [PATCH v3 05/10] block/pflash_cfi02: Implement nonuniform sector sizes |
Date: |
Thu, 18 Apr 2019 06:25:29 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 18/04/2019 00.01, Stephen Checkoway wrote:
> Some flash chips support sectors of different sizes. For example, the
> AMD AM29LV160DT has 31 64 kB sectors, one 32 kB sector, two 8 kB
> sectors, and a 16 kB sector, in that order. The AM29LV160DB has those in
> the reverse order.
>
> The `num-blocks` and `sector-length` properties work exactly as they did
> before: a flash device with uniform sector lengths. To get non-uniform
> sector lengths for up to four regions, the following properties may be
> set
> - region 0. `num-blocks0` and `sector-length0`;
> - region 1. `num-blocks1` and `sector-length1`;
> - region 2. `num-blocks2` and `sector-length2`; and
> - region 3. `num-blocks3` and `sector-length3`.
>
> If the uniform and nonuniform properties are set, then both must specify
> a flash device with the same total size. It would be better to disallow
> both being set, or make `num-blocks0` and `sector-length0` alias
> `num-blocks` and `sector-length`, but that would make testing currently
> impossible.
>
> Signed-off-by: Stephen Checkoway <address@hidden>
> ---
> hw/block/pflash_cfi02.c | 177 +++++++++++++++++++++++++-----------
> tests/pflash-cfi02-test.c | 185 ++++++++++++++++++++++++++++----------
> 2 files changed, 265 insertions(+), 97 deletions(-)
Acked-by: Thomas Huth <address@hidden>
- Re: [Qemu-block] [PATCH v3 01/10] block/pflash_cfi02: Add test for supported commands, (continued)
- [Qemu-block] [PATCH v3 03/10] block/pflash_cfi02: Fix command address comparison, Stephen Checkoway, 2019/04/17
- [Qemu-block] [PATCH v3 02/10] block/pflash_cfi02: Refactor, NFC intended, Stephen Checkoway, 2019/04/17
- [Qemu-block] [PATCH v3 06/10] block/pflash_cfi02: Fix CFI in autoselect mode, Stephen Checkoway, 2019/04/17
- [Qemu-block] [PATCH v3 07/10] block/pflash_cfi02: Fix reset command not ignored during erase, Stephen Checkoway, 2019/04/17
- [Qemu-block] [PATCH v3 08/10] block/pflash_cfi02: Implement multi-sector erase, Stephen Checkoway, 2019/04/17
- [Qemu-block] [PATCH v3 05/10] block/pflash_cfi02: Implement nonuniform sector sizes, Stephen Checkoway, 2019/04/17
- Re: [Qemu-block] [PATCH v3 05/10] block/pflash_cfi02: Implement nonuniform sector sizes,
Thomas Huth <=
- [Qemu-block] [PATCH v3 10/10] block/pflash_cfi02: Use the chip erase time specified in the CFI table, Stephen Checkoway, 2019/04/17
- [Qemu-block] [PATCH v3 04/10] block/pflash_cfi02: Implement intereleaved flash devices, Stephen Checkoway, 2019/04/17
- [Qemu-block] [PATCH v3 09/10] block/pflash_cfi02: Implement erase suspend/resume, Stephen Checkoway, 2019/04/17