[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH for-4.0? 2/4] qcow2: Fix preallocation bdrv_pwri
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH for-4.0? 2/4] qcow2: Fix preallocation bdrv_pwrite to wrong file |
Date: |
Mon, 15 Apr 2019 11:17:50 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 4/15/19 10:54 AM, Kevin Wolf wrote:
> With an external data file, preallocate_co() must write the final byte
> to the external data file, not to the qcow2 image file.
>
> This is harmless for preallocation of newly created images (only the
> qcow2 file size is increased to the virtual disk size while it should be
> much smaller), but with preallocated resize, it could in theory cause
> visible corruption if the metadata of the image is larger than the data
> (e.g. lots of bitmaps).
Can we come up with such an image - maybe one with 512-byte cluster
sizing and only 1k in guest-visible length? Since each bitmap is
cluster-aligned, it seems like you'd only need a couple of bitmaps to
easily reach that point.
We're awfully late for 4.0, but as we already have -rc4 coming due, and
as this is a data-corruption bug in a new feature, I can buy the
argument of getting this one into 4.0, particularly if you can design
the iotest along the lines of my ideas to prove that yes, indeed, we are
accidentally wiping out qcow2 metadata for visible image corruption.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH 0/4] qcow2: Preallocation fixes, Kevin Wolf, 2019/04/15
- [Qemu-block] [PATCH 1/4] qcow2: Avoid COW during metadata preallocation, Kevin Wolf, 2019/04/15
- [Qemu-block] [PATCH for-4.0? 2/4] qcow2: Fix preallocation bdrv_pwrite to wrong file, Kevin Wolf, 2019/04/15
- Re: [Qemu-block] [PATCH for-4.0? 2/4] qcow2: Fix preallocation bdrv_pwrite to wrong file,
Eric Blake <=
- [Qemu-block] [PATCH 4/4] qcow2: Fix full preallocation with external data file, Kevin Wolf, 2019/04/15
- [Qemu-block] [PATCH 3/4] qcow2: Add errp to preallocate_co(), Kevin Wolf, 2019/04/15
- Re: [Qemu-block] [PATCH 0/4] qcow2: Preallocation fixes, Kevin Wolf, 2019/04/29