[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 01/10] block/pflash_cfi02: Add test
From: |
Thomas Huth |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 01/10] block/pflash_cfi02: Add test for supported commands |
Date: |
Tue, 9 Apr 2019 10:16:33 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 09/04/2019 09.45, Markus Armbruster wrote:
> Thomas Huth <address@hidden> writes:
>
>> We'd like to get rid of global_qtest in the long run (since it is
>> causing trouble for tests that run multiple instances of QEMU in
>> parallel, e.g. migration tests)... so if it is feasible, please don't
>> use it in new code anymore. Try to use a local variable in the function
>> that call qtest_initf() and pass the test state around via a parameter
>> to the functions that need it.
>
> Twenty tests still use @global_qtest
>
> Either we're serious about getting rid of @global_qtest. Then we should
> just do it.
Ha ha, "just do it" ... that's quite a bit of work, actually. It's not
just about grep'ing for global_qtest, you also have to replace all the
writel(), readl() etc. functions with qtest_writel(), qtest_readl() etc.
If you feel like this is a "just do it" quick task, you're welcome to help!
> Or we're not. Then we shouldn't ask contributors to do extra work.
We are:
git log --oneline -- tests | grep global_qtest
... it just takes time.
Thomas
[Qemu-block] [PATCH 02/10] block/pflash_cfi02: Refactor, NFC intended, Stephen Checkoway, 2019/04/08
[Qemu-block] [PATCH 03/10] block/pflash_cfi02: Fix command address comparison, Stephen Checkoway, 2019/04/08
[Qemu-block] [PATCH 07/10] block/pflash_cfi02: Fix reset command not ignored during erase, Stephen Checkoway, 2019/04/08
[Qemu-block] [PATCH 06/10] block/pflash_cfi02: Fix CFI in autoselect mode, Stephen Checkoway, 2019/04/08
[Qemu-block] [PATCH 04/10] block/pflash_cfi02: Implement intereleaved flash devices, Stephen Checkoway, 2019/04/08