[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 3/7] nbd/server: Don't fail NBD_OPT_INFO for byt
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
Re: [Qemu-block] [PATCH 3/7] nbd/server: Don't fail NBD_OPT_INFO for byte-aligned sources |
Date: |
Fri, 5 Apr 2019 15:34:32 +0000 |
03.04.2019 6:05, Eric Blake wrote:
> In commit 0c1d50bd, I added a couple of TODO comments about whether we
> consult bl.request_alignment when responding to NBD_OPT_INFO. At the
> time, qemu as server was hard-coding an advertised alignment of 512 to
> clients that promised to obey constraints, and there was no function
> for getting at a device's preferred alignment. But in hindsight,
> advertising 512 when the block device prefers 1 caused other
> compliance problems, and commit b0245d64 changed one of the two TODO
> comments to advertise a more accurate alignment. Time to fix the other
> TODO. Doesn't really impact qemu as client (our normal client doesn't
> use NBD_OPT_INFO, and qemu-nbd --list promises to obey block sizes),
> but it might prove useful to other clients.
>
> Fixes: b0245d64
> Signed-off-by: Eric Blake <address@hidden>
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
--
Best regards,
Vladimir
[Qemu-block] [PATCH 3/7] nbd/server: Don't fail NBD_OPT_INFO for byte-aligned sources, Eric Blake, 2019/04/02
- Re: [Qemu-block] [PATCH 3/7] nbd/server: Don't fail NBD_OPT_INFO for byte-aligned sources,
Vladimir Sementsov-Ogievskiy <=
[Qemu-block] [PATCH 4/7] iotests: Update 241 to expose backing layer fragmentation, Eric Blake, 2019/04/02
[Qemu-block] [PATCH 5/7] block: Fix BDRV_BLOCK_RAW status to honor alignment, Eric Blake, 2019/04/02
[Qemu-block] [PATCH 6/7] nbd/server: Avoid unaligned read/block_status from backing, Eric Blake, 2019/04/02
[Qemu-block] [PATCH for-4.1 7/7] nbd/server: Avoid unaligned dirty-bitmap status, Eric Blake, 2019/04/02
[Qemu-block] [PATCH for-4.0? 8/7] nbd/client: Fix error message for server with unusable sizing, Eric Blake, 2019/04/04