[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH for-4.0? 8/7] nbd/client: Fix error message for serv
From: |
Eric Blake |
Subject: |
[Qemu-block] [PATCH for-4.0? 8/7] nbd/client: Fix error message for server with unusable sizing |
Date: |
Thu, 4 Apr 2019 09:52:26 -0500 |
Add a missing space to the error message used when giving up on a
server that insists on an alignment which renders the last few bytes
of the export unreadable.
Fixes: 3add3ab78
Signed-off-by: Eric Blake <address@hidden>
---
We've already concluded that 5-7 are too risky for 4.0 (so qemu 4.0
NBD servers will have non-compliance issues in alignment corner cases,
although in fewer places than where 3.1 had similar bugs; and the 4.0
client is able to work around those non-compliance cases). But I'd
still like a review on 1-3 and this patch 8, as trivial improvements
worth having in 4.0. I'm borderline on whether having patch 4 in 4.0
adds any value.
nbd/client.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/nbd/client.c b/nbd/client.c
index 427980bdd22..4de30630c73 100644
--- a/nbd/client.c
+++ b/nbd/client.c
@@ -428,7 +428,7 @@ static int nbd_opt_info_or_go(QIOChannel *ioc, uint32_t opt,
}
if (info->min_block &&
!QEMU_IS_ALIGNED(info->size, info->min_block)) {
- error_setg(errp, "export size %" PRIu64 "is not multiple of "
+ error_setg(errp, "export size %" PRIu64 " is not multiple of "
"minimum block size %" PRIu32, info->size,
info->min_block);
nbd_send_opt_abort(ioc);
--
2.20.1
- [Qemu-block] [PATCH 3/7] nbd/server: Don't fail NBD_OPT_INFO for byte-aligned sources, (continued)
- [Qemu-block] [PATCH 3/7] nbd/server: Don't fail NBD_OPT_INFO for byte-aligned sources, Eric Blake, 2019/04/02
- [Qemu-block] [PATCH 4/7] iotests: Update 241 to expose backing layer fragmentation, Eric Blake, 2019/04/02
- [Qemu-block] [PATCH 5/7] block: Fix BDRV_BLOCK_RAW status to honor alignment, Eric Blake, 2019/04/02
- [Qemu-block] [PATCH 6/7] nbd/server: Avoid unaligned read/block_status from backing, Eric Blake, 2019/04/02
- [Qemu-block] [PATCH for-4.1 7/7] nbd/server: Avoid unaligned dirty-bitmap status, Eric Blake, 2019/04/02
- [Qemu-block] [PATCH for-4.0? 8/7] nbd/client: Fix error message for server with unusable sizing,
Eric Blake <=