[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v10 06/21] acpi/ghes: Remove a duplicated out of bounds check
From: |
Mauro Carvalho Chehab |
Subject: |
[PATCH v10 06/21] acpi/ghes: Remove a duplicated out of bounds check |
Date: |
Sat, 14 Sep 2024 08:13:27 +0200 |
acpi_ghes_record_errors() has an assert() at the beginning
to ensure that source_id will be lower than
ACPI_GHES_ERROR_SOURCE_COUNT. Remove a duplicated check.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---
hw/acpi/ghes.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c
index 939e89723a2f..36fe5f68782f 100644
--- a/hw/acpi/ghes.c
+++ b/hw/acpi/ghes.c
@@ -420,9 +420,7 @@ int acpi_ghes_record_errors(uint8_t source_id, uint64_t
physical_address)
return -1;
}
- if (source_id < ACPI_GHES_ERROR_SOURCE_COUNT) {
- start_addr += source_id * sizeof(uint64_t);
- }
+ start_addr += source_id * sizeof(uint64_t);
cpu_physical_memory_read(start_addr, &error_block_addr,
sizeof(error_block_addr));
--
2.46.0
- [PATCH v10 01/21] acpi/ghes: add a firmware file with HEST address, (continued)
- [PATCH v10 01/21] acpi/ghes: add a firmware file with HEST address, Mauro Carvalho Chehab, 2024/09/14
- [PATCH v10 14/21] acpi/ghes: add a notifier to notify when error data is ready, Mauro Carvalho Chehab, 2024/09/14
- [PATCH v10 03/21] acpi/ghes: get rid of ACPI_HEST_SRC_ID_RESERVED, Mauro Carvalho Chehab, 2024/09/14
- [PATCH v10 07/21] acpi/ghes: rework the logic to handle HEST source ID, Mauro Carvalho Chehab, 2024/09/14
- [PATCH v10 17/21] qapi/acpi-hest: add an interface to do generic CPER error injection, Mauro Carvalho Chehab, 2024/09/14
- [PATCH v10 04/21] acpi/ghes: simplify acpi_ghes_record_errors() code, Mauro Carvalho Chehab, 2024/09/14
- [PATCH v10 06/21] acpi/ghes: Remove a duplicated out of bounds check,
Mauro Carvalho Chehab <=
- [PATCH v10 16/21] arm/virt: Wire up a GED error device for ACPI / GHES, Mauro Carvalho Chehab, 2024/09/14
- [PATCH v10 11/21] acpi/ghes: don't crash QEMU if ghes GED is not found, Mauro Carvalho Chehab, 2024/09/14
- [PATCH v10 12/21] acpi/ghes: rename etc/hardware_error file macros, Mauro Carvalho Chehab, 2024/09/14
- [PATCH v10 05/21] acpi/ghes: better handle source_id and notification, Mauro Carvalho Chehab, 2024/09/14
- [PATCH v10 20/21] target/arm: add an experimental mpidr arm cpu property object, Mauro Carvalho Chehab, 2024/09/14
- [PATCH v10 08/21] acpi/ghes: Change the type for source_id, Mauro Carvalho Chehab, 2024/09/14
- [PATCH v10 13/21] acpi/ghes: better name GHES memory error function, Mauro Carvalho Chehab, 2024/09/14