Re: [PATCH 1/8] hw/pci-host/designware: Declare CPU QOM types using DEFINE_TYPES() macro

[Philippe Mathieu-Daudé]

On 19/8/24 06:21, Gustavo Romero wrote:
> Hi Phil,
>
> On 10/12/23 9:18 AM, Philippe Mathieu-Daudé wrote:
> > When multiple QOM types are registered in the same file,
> > it is simpler to use the the DEFINE_TYPES() macro. In
> > particular because type array declared with such macro
> > are easier to review.
> >
> > Remove a pointless structure declaration in "designware.h".
> >
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> > ---
> >   include/hw/pci-host/designware.h |  2 --
> >   hw/pci-host/designware.c         | 39 ++++++++++++++------------------
> >   2 files changed, 17 insertions(+), 24 deletions(-)


> Reviewed-by: Gustavo Romero <gustavo.romero@linaro.org>
>
> This patch can get merged independently of this series.

OK, thank you!