[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 2/2] aspeed/sdmc: Remove extra R_MAIN_STATUS case
From: |
Jamin Lin |
Subject: |
[PATCH v2 2/2] aspeed/sdmc: Remove extra R_MAIN_STATUS case |
Date: |
Tue, 25 Jun 2024 09:50:28 +0800 |
Coverity reports that the newly added 'case R_MAIN_STATUS' is DEADCODE
because it can not be reached. This is because R_MAIN_STATUS is handled
before in the "Unprotected registers" switch statement. Remove it.
Fixes: Coverity CID 1547112
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
[ clg: Rewrote commit log ]
Signed-off-by: Cédric Le Goater <clg@redhat.com>
---
hw/misc/aspeed_sdmc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/misc/aspeed_sdmc.c b/hw/misc/aspeed_sdmc.c
index 93e2e29ead..94eed9264d 100644
--- a/hw/misc/aspeed_sdmc.c
+++ b/hw/misc/aspeed_sdmc.c
@@ -589,7 +589,6 @@ static void aspeed_2700_sdmc_write(AspeedSDMCState *s,
uint32_t reg,
case R_INT_STATUS:
case R_INT_CLEAR:
case R_INT_MASK:
- case R_MAIN_STATUS:
case R_ERR_STATUS:
case R_ECC_FAIL_STATUS:
case R_ECC_FAIL_ADDR:
--
2.25.1
- [PATCH v2 0/2] Fix coverity issues for AST2700, Jamin Lin, 2024/06/24
- [PATCH v2 1/2] aspeed/soc: Fix possible divide by zero, Jamin Lin, 2024/06/24
- Re: [PATCH v2 1/2] aspeed/soc: Fix possible divide by zero, cmd, 2024/06/25
- Re: [PATCH v2 1/2] aspeed/soc: Fix possible divide by zero, Cédric Le Goater, 2024/06/25
- Re: [PATCH v2 1/2] aspeed/soc: Fix possible divide by zero, cmd, 2024/06/25
- RE: [PATCH v2 1/2] aspeed/soc: Fix possible divide by zero, Jamin Lin, 2024/06/25
- Re: [PATCH v2 1/2] aspeed/soc: Fix possible divide by zero, Cédric Le Goater, 2024/06/25
- RE: [PATCH v2 1/2] aspeed/soc: Fix possible divide by zero, Jamin Lin, 2024/06/25
[PATCH v2 2/2] aspeed/sdmc: Remove extra R_MAIN_STATUS case,
Jamin Lin <=