[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] hw/arm/virt-acpi-build: Fix id_count in build_iort_id_map
From: |
Nicolin Chen |
Subject: |
Re: [PATCH v3] hw/arm/virt-acpi-build: Fix id_count in build_iort_id_mapping |
Date: |
Tue, 18 Jun 2024 14:19:25 -0700 |
On Tue, Jun 18, 2024 at 05:14:32PM -0400, Michael S. Tsirkin wrote:
> > @@ -306,8 +314,8 @@ build_iort(GArray *table_data, BIOSLinker *linker,
> > VirtMachineState *vms)
> > }
> >
> > /* Append the last RC -> ITS ID mapping */
> > - if (next_range.input_base < 0xFFFF) {
> > - next_range.id_count = 0xFFFF - next_range.input_base;
> > + if (next_range.input_base < 0x10000) {
> > + next_range.id_count = 0x10000 - next_range.input_base;
> > g_array_append_val(its_idmaps, next_range);
> > }
>
> A change of logic here - I think the new one is right and old
> one was wrong, actually. Right?
Sorry, I don't quite follow that question...
Doesn't a patch correct an old wrong one to a new right one?
Thanks
Nicolin
Re: [PATCH v3] hw/arm/virt-acpi-build: Fix id_count in build_iort_id_mapping, Eric Auger, 2024/06/19