Re: [PATCH 1/1] BootLogoLib: align logo coords to be even

[Marcin Juszkiewicz]

W dniu 17.06.2024 o 10:39, Ard Biesheuvel pisze:
> > If we draw logo at odd coords then BootLogoLib goes into exception and
> > boot process ends:
> >
> > Synchronous Exception at 0x00000101FB943E48
> > PC 0x0101FB943E48 (0x0101FB93F000+0x00004E48) [ 0] QemuVideoDxe.dll
> > PC 0x0101FB943314 (0x0101FB93F000+0x00004314) [ 0] QemuVideoDxe.dll
> > PC 0x0101FB92F798 (0x0101FB92D000+0x00002798) [ 1] ConSplitterDxe.dll
> > PC 0x0101FBA96BC4 (0x0101FBA8E000+0x00008BC4) [ 2] BdsDxe.dll
> > PC 0x0101FF7FDF50 (0x0101FF7F3000+0x0000AF50) [ 3] DxeCore.dll
> >
> > This change resizes logo from 193x58 to 194x58px to make it's sizes
> > even. And if coords are odd then they are bumped a bit to make things
> > work.
> >
> > Signed-off-by: Marcin Juszkiewicz<marcin.juszkiewicz@linaro.org>

> This should be fixed in the SBSA firmware

One coffee was not enough so I sent it to QEMU devel instead of EDK2 
devel mailing list...

> unaligned accesses are fine on arm64 as long as they don't target
> device memory. So this likely implies that the framebuffer is
> mapped with device attributes while it should be mapped  > normal-non-cacheable.

OK, so need to go through QEMU source now.