Re: [PULL 0/9] Python patches

[John Snow]

On Thu, Oct 5, 2023, 9:00 AM Stefan Hajnoczi <stefanha@gmail.com> wrote:

On Thu, 5 Oct 2023 at 00:49, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> Hi John,
>
> On 4/10/23 21:46, John Snow wrote:
> > The following changes since commit da1034094d375afe9e3d8ec8980550ea0f06f7e0:
> >
> >    Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2023-10-03 07:43:44 -0400)
> >
> > are available in the Git repository at:
> >
> >    https://gitlab.com/jsnow/qemu.git tags/python-pull-request
> >
> > for you to fetch changes up to 4d7a663cbe8343e884b88e44bd88d37dd0a470e5:
> >
> >    Python: test Python 3.12 (2023-10-04 15:19:00 -0400)
> >
> > ----------------------------------------------------------------
> > Python pullreq
> >
> > Buffering improvements for qemu machine, minor changes to support the
> > newly released Python 3.12
> >
> > ----------------------------------------------------------------
> >
> > John Snow (9):
> >    Python/iotests: Add type hint for nbd module
> >    python/machine: move socket setup out of _base_args property
> >    python/machine: close sock_pair in cleanup path
> >    python/console_socket: accept existing FD in initializer
> >    python/machine: use socketpair() for console connections
> >    python/machine: use socketpair() for qtest connection
> >    python/machine: remove unused sock_dir argument
> >    python/qmp: remove Server.wait_closed() call for Python 3.12
> >    Python: test Python 3.12
>
> Is that a pull request or a patch series to be reviewed?

Strange, some of the patches have Reviewed-by tags but others do not.
I could not find a "Add type hint for nbd module" patch on the mailing
list before this pull request, so I guess it hasn't been reviewed.

I'll hold off from merging this series for now.

John: Please make sure all patches have been on the mailing list for
review before sending a pull request.

Stefan

Okey Dokey.

--js