[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 04/12] docs/style: permit inline loop variables
From: |
Alex Bennée |
Subject: |
[PATCH v3 04/12] docs/style: permit inline loop variables |
Date: |
Tue, 29 Aug 2023 17:15:20 +0100 |
I've already wasted enough of my time debugging aliased variables in
deeply nested loops. While not scattering variable declarations around
is a good aim I think we can make an exception for stuff used inside a
loop.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Acked-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20230822155004.1158931-1-alex.bennee@linaro.org>
---
docs/devel/style.rst | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/docs/devel/style.rst b/docs/devel/style.rst
index 3cfcdeb9cd..2f68b50079 100644
--- a/docs/devel/style.rst
+++ b/docs/devel/style.rst
@@ -204,7 +204,14 @@ Declarations
Mixed declarations (interleaving statements and declarations within
blocks) are generally not allowed; declarations should be at the beginning
-of blocks.
+of blocks. To avoid accidental re-use it is permissible to declare
+loop variables inside for loops:
+
+.. code-block:: c
+
+ for (int i = 0; i < ARRAY_SIZE(thing); i++) {
+ /* do something loopy */
+ }
Every now and then, an exception is made for declarations inside a
#ifdef or #ifndef block: if the code looks nicer, such declarations can
--
2.39.2
- [PATCH v3 00/12] gdbstub and testing fixes for 8.2 (pre-PR), Alex Bennée, 2023/08/29
- [PATCH v3 02/12] tests/docker: cleanup non-verbose output, Alex Bennée, 2023/08/29
- [PATCH v3 01/12] gitlab: enable ccache for many build jobs, Alex Bennée, 2023/08/29
- [PATCH v3 03/12] tests/tcg: remove quoting for info output, Alex Bennée, 2023/08/29
- [PATCH v3 05/12] .gitlab-ci.d/cirrus.yml: Update FreeBSD to v13.2, Alex Bennée, 2023/08/29
- [PATCH v3 11/12] gdbstub: replace global gdb_has_xml with a function, Alex Bennée, 2023/08/29
- [PATCH v3 10/12] gdbstub: refactor get_feature_xml, Alex Bennée, 2023/08/29
- [PATCH v3 09/12] gdbstub: remove unused user_ctx field, Alex Bennée, 2023/08/29
- [PATCH v3 04/12] docs/style: permit inline loop variables,
Alex Bennée <=
- [PATCH v3 07/12] tests/tcg: clean-up gdb confirm/pagination settings, Alex Bennée, 2023/08/29
- [PATCH v3 06/12] tests: remove test-gdbstub.py, Alex Bennée, 2023/08/29
- [PATCH v3 12/12] gdbstub: move comment for gdb_register_coprocessor, Alex Bennée, 2023/08/29
- [PATCH v3 08/12] gdbstub: fixes cases where wrong threads were reported to GDB on SIGINT, Alex Bennée, 2023/08/29